Skip to content

[14.0][IMP] queue_job: use a widget in eta field in queue job tree view - #388

Merged
OCA-git-bot merged 1 commit into
OCA:14.0from
vauxoo-dev:14.0-set-widget-date-queue-eta-fer
Jan 18, 2022
Merged

[14.0][IMP] queue_job: use a widget in eta field in queue job tree view#388
OCA-git-bot merged 1 commit into
OCA:14.0from
vauxoo-dev:14.0-set-widget-date-queue-eta-fer

Conversation

@fernandahf

@fernandahffernandahf commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

Description of the issue/feature this PR addresses:

There is no issue, otherwise an improvement in queue job tree view, in order to user identifies clearly remaining days of ETA of queue job (in case of have ETA)

Screen Shot 2021-11-04 at 11 35 36

Also, this PR disables lint duplicate-xml-fields due to in v14.0 is allowed.

Current behavior before PR:
Queue job tree view showing ETA field with datetime.

Desired behavior after PR is merged:
Queue job tree view showing ETA field with remaining days widget, user can see clearly remaining days to the job is executed.

-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@pedrobaezapedrobaeza changed the title [IMP] queue_job: use a widget in eta field in queue job tree view[14.0][IMP] queue_job: use a widget in eta field in queue job tree viewNov 4, 2021
@pedrobaeza

Copy link
Copy Markdown
Member

If the remaining time is less a day, are hours displayed as well?

@fernandahf

Copy link
Copy Markdown
ContributorAuthor

it's showing Today:

Screen Shot 2021-11-04 at 12 11 59

cc @moylop260

@pedrobaeza

Copy link
Copy Markdown
Member

I think that limits a bit the usefulness, as you want to see the exact hour for being executed, but I let the rest to give their opinion.

@fernandahf
fernandahfforce-pushed the 14.0-set-widget-date-queue-eta-fer branch from 9ec3596 to c56817cCompareNovember 4, 2021 19:05
@guewen

Copy link
Copy Markdown
Member

It would be nice if it shows "in 4 minutes", but I find Today too large. Having the information that a job is executed in 22 or 24 days is not really decisive, but in 2 minutes or 6 hours is.

So I don't find this to be an improvement.

I like the idea though and thanks for proposing it.

@guewen

Copy link
Copy Markdown
Member

Oh I didn't see it was beside the other one. So my only concern is the place it takes. Maybe add a visibility? hidden by default?

@fernandahf
fernandahfforce-pushed the 14.0-set-widget-date-queue-eta-fer branch from c56817c to 0f72422CompareNovember 9, 2021 16:03
@fernandahf

Copy link
Copy Markdown
ContributorAuthor

@guewen

I hid the field by default.

cc @moylop260

@guewenguewen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fernandahf
fernandahfforce-pushed the 14.0-set-widget-date-queue-eta-fer branch from 0f72422 to 1954a8eCompareNovember 9, 2021 19:41
@fernandahf

Copy link
Copy Markdown
ContributorAuthor

@guewen

There is an error in Actions of PR related to a dependency:

https://github.com/vauxoo-dev/queue/runs/4156961482?check_suite_focus=true

AttributeError: module 'collections' has no attribute 'MutableSet'

Could you review it, please?

cc @moylop260

@fernandahf
fernandahfforce-pushed the 14.0-set-widget-date-queue-eta-fer branch from 1954a8e to ec173cfCompareJanuary 18, 2022 16:20
@fernandahf

Copy link
Copy Markdown
ContributorAuthor

@guewen

Is there something to do with my side in this PR?

@guewen

Copy link
Copy Markdown
Member

No, I was waiting for a second review as we are supposed to do.

Sorry for the inconvenience and thank you for your PR

/ocabot merge minor

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-388-by-guewen-bump-minor, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at d64e42f. Thanks a lot for contributing to OCA. ❤️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@fernandahf@pedrobaeza@guewen@OCA-git-bot@dreispt