Skip to content

[MIG][15.0] queue_job_cron to version 15.0 - #410

Merged
OCA-git-bot merged 1 commit into
OCA:15.0from
ForgeFlow:15.0-mig-queue_job_cron
Apr 29, 2022
Merged

[MIG][15.0] queue_job_cron to version 15.0#410
OCA-git-bot merged 1 commit into
OCA:15.0from
ForgeFlow:15.0-mig-queue_job_cron

Conversation

@JoanMForgeFlow

@JoanMForgeFlowJoanMForgeFlow commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

Standard migration to version 15.0

@JoanMForgeFlow
JoanMForgeFlowforce-pushed the 15.0-mig-queue_job_cron branch from 0df6d93 to 103456eCompareMarch 1, 2022 08:30
AaronHForgeFlow
AaronHForgeFlow approved these changes Mar 1, 2022
View reviewed changes

@AaronHForgeFlowAaronHForgeFlow left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

mariadforgeflow
mariadforgeflow approved these changes Mar 11, 2022
View reviewed changes

@mariadforgeflowmariadforgeflow left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot

OCA-git-bot commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

simahawk
simahawk approved these changes Mar 11, 2022
View reviewed changes

@simahawksimahawk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@simahawk

simahawk commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@simahawk

simahawk commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

/ocabot migration queue_job_cron

@OCA-git-bot

OCA-git-bot commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-410-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 11, 2022
@OCA-git-bot
Merge PR#410into 15.0
f08e2f2
Signed-off-by simahawk
@OCA-git-botOCA-git-bot added this to the 15.0 milestone Mar 11, 2022
@OCA-git-botOCA-git-bot mentioned this pull request Mar 11, 2022
Closed
10 tasks
@OCA-git-bot

OCA-git-bot commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-410-by-simahawk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@AaronHForgeFlow

AaronHForgeFlow commented Apr 29, 2022

Copy link
Copy Markdown

I think the CI failed because of an infrastructure thing. Probably retrying the merge will succeed. Can you do so @simahawk ?

@simahawk

simahawk commented Apr 29, 2022

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Apr 29, 2022

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-410-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit fbe33ad into OCA:15.0Apr 29, 2022
@OCA-git-bot

OCA-git-bot commented Apr 29, 2022

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 4502fe5. Thanks a lot for contributing to OCA. ❤️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawksimahawksimahawk approved these changes
+2 more reviewers
@AaronHForgeFlowAaronHForgeFlowAaronHForgeFlow approved these changes
@mariadforgeflowmariadforgeflowmariadforgeflow approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedmerged 🎉ready to merge

Projects

None yet

Milestone

15.0

Development

Successfully merging this pull request may close these issues.

5 participants

@JoanMForgeFlow@OCA-git-bot@simahawk@AaronHForgeFlow@mariadforgeflow