[14.0][FIX] It seems that sometimes jobs doesn't have a job_method and the __repr__ failed

[acsonefho]

That fix the issue into Shopinvader: https://github.com/shopinvader/odoo-shopinvader/runs/6897055192?check_suite_focus=true#step:8:7767 (cfr screenshot).
The issue happens into every PR in v14.0 (during merge or after a rebase).

The issue happens during the call to the __repr__ of the Delayable object when the attribute _job_method is None.
https://github.com/OCA/queue/blob/14.0/queue_job/delay.py#L496
I didn't clearly identify why the _job_method is not filled. So maybe this PR is not a good solution.

[OCA-git-bot]

Hi @guewen,
some modules you are maintaining are being modified, check this out!

[rousseldenis]

@acsonefho is there a mean to write a test to reproduce?

[rousseldenis]

Shouldn't it be something more user friendly than a void string ?

[acsonefho]

That happens when the current object is related to nothing. So what do you propose? :)

[rousseldenis]

@guewen What do you think of this ?

[rousseldenis]

Quite trivial as job_method slot is None by default.

Even if this could be enhanced, this is sufficient to avoid errors

[guewen]

We see in the traceback that it happens in the __del__ method, where we check that we didn't create a Delayable that we forgot to delay(). It repr the delayable not delayed. Do you have an idea why we fall in this case in the first place?

[acsonefho]

We see in the traceback that it happens in the __del__ method, where we check that we didn't create a Delayable that we forgot to delay(). It repr the delayable not delayed. Do you have an idea why we fall in this case in the first place?

Thanks for the review.
But I really don't know and I can't reproduce it :/

[guewen]

/ocabot merge patch

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-440-by-guewen-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 5a6a806. Thanks a lot for contributing to OCA. ❤️