Skip to content

[ADD][14.0] queue_job_context - #462

Merged
OCA-git-bot merged 1 commit into
OCA:14.0from
AshishHirapara:14.0-queue_job_context
Oct 19, 2022
Merged

[ADD][14.0] queue_job_context#462
OCA-git-bot merged 1 commit into
OCA:14.0from
AshishHirapara:14.0-queue_job_context

Conversation

@AshishHirapara

@AshishHiraparaAshishHirapara commented Oct 13, 2022

Copy link
Copy Markdown

initial commit - Add context before queue

francesco-ooops
francesco-ooops reviewed Oct 13, 2022
View reviewed changes
Comment threadqueue_job_context/__manifest__.py Outdated
Comment threadqueue_job_context/readme/CONTRIBUTORS.rst Outdated
Comment threadqueue_job_context/readme/CONFIGURE.rst Outdated
@AshishHirapara
AshishHiraparaforce-pushed the 14.0-queue_job_context branch 3 times, most recently from 977f9ab to cd4a6d2CompareOctober 14, 2022 03:35
@francesco-ooopsfrancesco-ooops mentioned this pull request Oct 14, 2022
Merged
sbidoul
sbidoul reviewed Oct 15, 2022
View reviewed changes
Comment threadqueue_job_context/readme/DESCRIPTION.rst Outdated
@sbidoul

sbidoul commented Oct 15, 2022

Copy link
Copy Markdown
Member

A small comment about the readme, otherwise looks good, thanks!

@hoangtrann

hoangtrann commented Oct 18, 2022

Copy link
Copy Markdown
Contributor

May I ask why we didn't include this behavior in #433?

@sbidoul

sbidoul commented Oct 18, 2022

Copy link
Copy Markdown
Member

May I ask why we didn't include this behavior in #433?

@hoangtrann for backward compatibility reasons.

In 16.0 this must be the default cc/ @baimont

sbidoul
sbidoul reviewed Oct 18, 2022
View reviewed changes
Comment threadqueue_job_context/__manifest__.py Outdated
sbidoul
sbidoul reviewed Oct 18, 2022
View reviewed changes
Comment threadqueue_job_context/readme/DESCRIPTION.rst Outdated
@AshishHirapara
[ADD][14.0] queue_job_context
d5d2ecb
initial commit - Add context before queue
@sbidoulsbidoul mentioned this pull request Oct 18, 2022
Merged
@francesco-ooops

francesco-ooops commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

@OCA/connector-infor-maintainers merge?

@sbidoul

sbidoul commented Oct 19, 2022

Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-462-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 3616f2f into OCA:14.0Oct 19, 2022
@OCA-git-bot

OCA-git-bot commented Oct 19, 2022

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 875b08b. Thanks a lot for contributing to OCA. ❤️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbidoulsbidoulsbidoul approved these changes
+1 more reviewer
@francesco-ooopsfrancesco-ooopsfrancesco-ooops left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AshishHirapara@sbidoul@hoangtrann@francesco-ooops@OCA-git-bot