Skip to content

[14.0][PORT] queue_job_cron_jobrunner: backport from 15.0 to 14.0 for queue_job_cron_jobrunner from 15.0 to 14.0 - #479

Merged
OCA-git-bot merged 3 commits into
OCA:14.0from
chrisb-c01:14.0-backport-queue_job_cron_jobrunner
Nov 17, 2022
Merged

[14.0][PORT] queue_job_cron_jobrunner: backport from 15.0 to 14.0 for queue_job_cron_jobrunner from 15.0 to 14.0#479
OCA-git-bot merged 3 commits into
OCA:14.0from
chrisb-c01:14.0-backport-queue_job_cron_jobrunner

Conversation

@chrisb-c01

Copy link
Copy Markdown

This is a backport of the queue_job_cron_jobrunner added in 15.0 branch to 14.0.

Because 15.0 uses ir.cron.trigger to schedule cron jobs through the cron._trigger(at) private method, in this backport I am 'just' setting the cron.nextcall attribute to the current time datetime.now() in [queue.job]._cron_trigger().

@chrisb-c01
chrisb-c01force-pushed the 14.0-backport-queue_job_cron_jobrunner branch 6 times, most recently from 5c561df to b13c602CompareNovember 1, 2022 07:56
@guewen

Copy link
Copy Markdown
Member

Hi @chrisb-c01, thanks!
Could you also add this commit that makes the module compatible with graph of dependencies?

@chrisb-c01
chrisb-c01force-pushed the 14.0-backport-queue_job_cron_jobrunner branch from b13c602 to 9513d9dCompareNovember 2, 2022 06:57
@chrisb-c01

Copy link
Copy Markdown
Author

Hi @chrisb-c01, thanks!
Could you also add this commit that makes the module compatible with graph of dependencies?

I've added the commit. Getting a pre-commit failure now but it seems to be an issue with pre-commit/Python.

@guewen

Copy link
Copy Markdown
Member

It seems to be solved or a transient issue, re-running the check gave a successful run.

Thanks!

@guewen

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-479-by-guewen-bump-nobump, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at c849a31. Thanks a lot for contributing to OCA. ❤️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@chrisb-c01@guewen@OCA-git-bot@ivantodorovich