Skip to content

[15.0][MIG] queue_job_batch, test_queue_job_batch: Migration to 15.0 - #500

Closed
amh-mw wants to merge 32 commits into
OCA:15.0from
amh-mw:15.0-mig-queue_job_batch
Closed

[15.0][MIG] queue_job_batch, test_queue_job_batch: Migration to 15.0#500
amh-mw wants to merge 32 commits into
OCA:15.0from
amh-mw:15.0-mig-queue_job_batch

Conversation

@amh-mw

Copy link
Copy Markdown
Member

No description provided.

etobellaand others added 27 commits January 22, 2023 09:17
[UPD] Update queue_job_batch.pot
* incorrect sintax in security rule
* change missleading name of security rule
standard migration and some little ux improvements: now hide
button is a fa-check button that on click just marks as read
the batch, do not navigate to it and updates immediately
the systray.
[UPD] Update queue_job_batch.pot
[UPD] Update queue_job_batch.pot
Currently translated at 100.0% (61 of 61 strings)
Translation: queue-12.0/queue-12.0-queue_job_batch
Translate-URL: https://translation.odoo-community.org/projects/queue-12-0/queue-12-0-queue_job_batch/fr/
[UPD] Update test_queue_job_batch.pot
[UPD] Update test_queue_job_batch.pot
@amh-mwamh-mw mentioned this pull request Jan 22, 2023
10 tasks
@amh-mw

Copy link
Copy Markdown
MemberAuthor

@agenterp Since you noticed the lack of this module in the 15.0 milestone, mind giving it a review?

@amh-mw
amh-mwforce-pushed the 15.0-mig-queue_job_batch branch from 93922ac to d0ae023CompareJanuary 22, 2023 14:31
@amh-mw
amh-mwforce-pushed the 15.0-mig-queue_job_batch branch from d0ae023 to 0f4b688CompareJanuary 22, 2023 14:34
@amh-mw

Copy link
Copy Markdown
MemberAuthor

@jans23 Would you mind reviewing this pull request?

@jans23

Copy link
Copy Markdown

Ok, will put it on our team's task list.

@alihashaam

Copy link
Copy Markdown

@amh-mw

There is a small issue with the way qweb is referenced in manifest file of queue_job_batch module of this PR.

as if you look in the base modules, it should be done as follow. This solved the error [1] for me as otherwise I was getting the error [1] that :

[1] Qweb template "queue_job_batch.view.Menu" not found

"assets": { "web.assets_qweb": [ "queue_job_batch/static/src/xml/systray.xml", ],

I would like to push this change but I dont have access to repo. How would you prefer I proceed?

@alihashaam

Copy link
Copy Markdown

@amh-mw

Please find our work in PR:
amh-mw#1

@jans23 the module was also reviewed and two other small changes were included in above PR.

[15.0][IMP] qweb reference changed in manifest file
@amh-mw

Copy link
Copy Markdown
MemberAuthor

@alihashaam Thanks for the help!

@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actionsgithub-actionsBot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 1, 2023
@amh-mw
amh-mw deleted the 15.0-mig-queue_job_batch branch December 20, 2023 16:45
@amh-mw

Copy link
Copy Markdown
MemberAuthor

Reopened as #633

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stalePR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@amh-mw@jans23@alihashaam@etobella@LoisRForgeFlow@OCA-git-bot@qgroulard@ypapouin@anothingguy