Uh oh!
There was an error while loading. Please reload this page.
[16.0] queue_job: unify no delay option - #521
Conversation
OCA-git-bot
commented
Feb 28, 2023
Hi @guewen, |
bef1eb4 to
5d03eaaCompareCurrent situation: * multiple keys for no good reason * half baked: not all of them used everywhere * no centralization * poor naming With this change we'll have: * 1 and only one key to disable via ctx: ``queue_job__no_delay`` * 1 and only one key to disable via os env: ``QUEUE_JOB__NO_DELAY`` * backward compatibility with deprecation for old keys
5d03eaa to
dff747cCompare
grindtildeath
left a comment
There was a problem hiding this comment.
Looks good overall. Is there any reason to use a double underscore in the name of ctx key and env var?
IMO it would be better to have a single underscore as in QUEUE_JOB_NO_DELAY to avoid potential troubles because it's not something that's easy to detect if you accidentally write only one.
simahawk
commented
Mar 1, 2023
Actually the env var has 2 underscores too. TBH this is just an approach I'm taking to identify keys by module especially if the are meant to be used in many many modules. So the |
guewen
commented
Apr 2, 2023
/ocabot merge minor |
OCA-git-bot
commented
Apr 2, 2023
This PR looks fantastic, let's merge it! |
OCA-git-bot
commented
Apr 2, 2023
Congratulations, your PR was merged at 216fe43. Thanks a lot for contributing to OCA. ❤️ |
Current situation:
With this change we'll have:
queue_job__no_delayQUEUE_JOB__NO_DELAY