Skip to content

[IMP] queue_job: Display warning before displaying big dependency graphs - #657

Merged
OCA-git-bot merged 1 commit into
OCA:14.0from
akretion:14.0-fix-queue_job-limit-dep-graph
Jun 9, 2024
Merged

[IMP] queue_job: Display warning before displaying big dependency graphs#657
OCA-git-bot merged 1 commit into
OCA:14.0from
akretion:14.0-fix-queue_job-limit-dep-graph

Conversation

@paradoxxxzero

@paradoxxxzeroparadoxxxzero commented Jun 4, 2024

Copy link
Copy Markdown
Contributor

Big dependency graphs currently slow down web page, this PR adds a warning in this case:

20240604_09h13m27s_grim

@paradoxxxzero
paradoxxxzeroforce-pushed the 14.0-fix-queue_job-limit-dep-graph branch from 9a18ac9 to f0511aaCompareJune 4, 2024 07:29
@OCA-git-bot

OCA-git-bot commented Jun 4, 2024

Copy link
Copy Markdown
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

amh-mw
amh-mw approved these changes Jun 4, 2024
View reviewed changes

@amh-mwamh-mw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot

OCA-git-bot commented Jun 9, 2024

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot

OCA-git-bot commented Jun 9, 2024

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

guewen
guewen approved these changes Jun 9, 2024
View reviewed changes

@guewenguewen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cool
Btw I'm curious what is the graph with so many nodes used for 😄

@guewen

guewen commented Jun 9, 2024

Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Jun 9, 2024

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-657-by-guewen-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit e107eb3 into OCA:14.0Jun 9, 2024
@OCA-git-bot

OCA-git-bot commented Jun 9, 2024

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at f17cd34. Thanks a lot for contributing to OCA. ❤️

@simahawksimahawk mentioned this pull request Oct 9, 2024
Merged
@florentxflorentx mentioned this pull request Dec 27, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guewenguewenguewen approved these changes
+2 more reviewers
@amh-mwamh-mwamh-mw approved these changes
@hparfrhparfrhparfr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedmerged 🎉ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@paradoxxxzero@OCA-git-bot@guewen@amh-mw@hparfr