Skip to content

[17.0] [IMP] queue_job: HA job runner using session level advisory lock - #673

Merged
OCA-git-bot merged 4 commits into
OCA:17.0from
acsone:17.0-forwardport-ha_runner-qgr
Mar 17, 2025
Merged

[17.0] [IMP] queue_job: HA job runner using session level advisory lock#673
OCA-git-bot merged 4 commits into
OCA:17.0from
acsone:17.0-forwardport-ha_runner-qgr

Conversation

@qgroulard

@qgroulardqgroulard commented Jul 18, 2024

Copy link
Copy Markdown
Contributor

Forward port of #668

@OCA-git-bot

OCA-git-bot commented Jul 18, 2024

Copy link
Copy Markdown
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

LoisRForgeFlow
LoisRForgeFlow approved these changes Oct 25, 2024
View reviewed changes

@LoisRForgeFlowLoisRForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LoisRForgeFlow

LoisRForgeFlow commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

@guewen@sbidoul anything missing to get this one merged?

@simahawk

simahawk commented Dec 6, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

It has been approved by @guewen here as well #668 yet @sbidoul had to provide feedback on odoo.sh if I'm not mistaken.

@sbidoul

sbidoul commented Dec 6, 2024

Copy link
Copy Markdown
Member

We deployed this on a 17.0 odoo.sh instance. It works and nobody yelled at us :)

Now this is not a high volume deployment.

I'm quite confident this PR is good, but we are going to deploy this on a couple of more intensive instances (not odoo.sh) to confirm. I would encourage others to to the same.

@sbidoulsbidoul mentioned this pull request Dec 6, 2024
Merged
@sbidoul
sbidoulforce-pushed the 17.0-forwardport-ha_runner-qgr branch from 918a966 to 992bc9bCompareDecember 6, 2024 08:44
@sbidoul

sbidoul commented Dec 6, 2024

Copy link
Copy Markdown
Member

Rebased

@LoisRForgeFlow

LoisRForgeFlow commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

Hi @sbidoul

Still no issues with this improvement from our side. How is it going in your instances? Do you think we can merge?

@sbidoul
sbidoulforce-pushed the 17.0-forwardport-ha_runner-qgr branch from 992bc9b to d9f38cbCompareMarch 17, 2025 12:54
@sbidoul

sbidoul commented Mar 17, 2025

Copy link
Copy Markdown
Member

Yes, let's merge. I have merged #748 and now this one.

Two great simplification in queue_job operations!

/ocabot merge minor

@OCA-git-bot

OCA-git-bot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-673-by-sbidoul-bump-minor, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 400d8d3 into OCA:17.0Mar 17, 2025
@OCA-git-bot

OCA-git-bot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at bd16ee3. Thanks a lot for contributing to OCA. ❤️

@sbidoul
sbidoul deleted the 17.0-forwardport-ha_runner-qgr branch March 17, 2025 13:23
@sbidoulsbidoul mentioned this pull request Mar 21, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guewenguewenguewen approved these changes
@gurneyalexgurneyalexgurneyalex approved these changes
+1 more reviewer
@LoisRForgeFlowLoisRForgeFlowLoisRForgeFlow approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedmerged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@qgroulard@OCA-git-bot@LoisRForgeFlow@simahawk@sbidoul@guewen@gurneyalex