Skip to content

[14.0][IMP] queue_job: perform_enqueued_jobs should filter the context - #738

Merged
OCA-git-bot merged 1 commit into
OCA:14.0from
florentx:14.0_trap_context
Apr 30, 2025
Merged

[14.0][IMP] queue_job: perform_enqueued_jobs should filter the context#738
OCA-git-bot merged 1 commit into
OCA:14.0from
florentx:14.0_trap_context

Conversation

@florentx

@florentxflorentx commented Jan 17, 2025

Copy link
Copy Markdown
Contributor

This enhancement is needed to write more accurate tests when the delayed method is context-sensitive.

We had a bug not identified during tests because of this :(

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@florentxflorentx changed the title [14.0][IMP] queue_jobs: perform_enqueued_jobs should filter the context[14.0][IMP] queue_job: perform_enqueued_jobs should filter the contextJan 17, 2025
@florentx
florentxforce-pushed the 14.0_trap_context branch 2 times, most recently from a2d94e3 to dd8c852CompareJanuary 24, 2025 19:13
StefanRijnhart
StefanRijnhart previously approved these changes Feb 5, 2025
Comment threadtest_queue_job/tests/test_delay_mocks.py
@StefanRijnhart
StefanRijnhart dismissed their stale reviewMarch 19, 2025 19:28

Dismissing my review as per other reviewer's comment.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk

Copy link
Copy Markdown
Contributor

/ocabot merge minor

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-738-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 200e979. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot
OCA-git-bot merged commit 622586d into OCA:14.0Apr 30, 2025
@florentx
florentx deleted the 14.0_trap_context branch May 8, 2025 11:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@florentx@OCA-git-bot@simahawk@StefanRijnhart@petrus-v