Skip to content

[18.0][IMP] queue_job: prevent invalid change of job status - #777

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
florentx:18.0_button_checks
Jan 2, 2026
Merged

[18.0][IMP] queue_job: prevent invalid change of job status#777
OCA-git-bot merged 1 commit into
OCA:18.0from
florentx:18.0_button_checks

Conversation

@florentx

@florentxflorentx commented Jun 2, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Currently the check of Job state before manual action is loose:

  • for button: check happens when the Form view is loaded. Later when operator presses button, there's no guarantee that job is the same status. It could be processed in the meantime.
  • for mass-change using wizard, the check exists only on 1 wizard.

Here the check is made at the level of the action, and applies for both scenarios: button or wizard

@OCA-git-bot

OCA-git-bot commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@florentx
florentx marked this pull request as ready for review June 2, 2025 15:25
sbidoul
sbidoul reviewed Jun 3, 2025
View reviewed changes
Comment threadqueue_job/models/queue_job.py Outdated
sbidoul
sbidoul reviewed Jun 3, 2025
View reviewed changes
Comment threadqueue_job/models/queue_job.py Outdated
sbidoul
sbidoul reviewed Jun 3, 2025
View reviewed changes

@sbidoulsbidoul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement. But I'm uncomfortable with the __state_in method parameter and it seems there is a change in requeue related to WAIT_DEPENDENCIES?

@florentx
florentxforce-pushed the 18.0_button_checks branch from 5af9666 to 6008490CompareJune 3, 2025 08:41
@github-actions

github-actionsBot commented Oct 12, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actionsgithub-actionsBot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 12, 2025
@simahawksimahawk removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 13, 2025
@sbidoul

sbidoul commented Jan 2, 2026

Copy link
Copy Markdown
Member

/ocabot merge patch

Thanks!

@OCA-git-bot

OCA-git-bot commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-777-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit e2b546f into OCA:18.0Jan 2, 2026
2 of 3 checks passed
@OCA-git-bot

OCA-git-bot commented Jan 2, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at c1d4c07. Thanks a lot for contributing to OCA. ❤️

@sbidoulsbidoul mentioned this pull request Jan 4, 2026
Merged
@guewenguewen mentioned this pull request Mar 23, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbidoulsbidoulsbidoul left review comments
@simahawksimahawksimahawk approved these changes
@guewenguewenguewen approved these changes
+1 more reviewer
@hoangtrannhoangtrannhoangtrann approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approvedmerged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@florentx@OCA-git-bot@sbidoul@simahawk@guewen@hoangtrann