Skip to content

[18.0][IMP] queue_job: more efficient ChannelJob sorting - #779

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
florentx:18.0_channeljob_enhanced
Jun 11, 2025
Merged

[18.0][IMP] queue_job: more efficient ChannelJob sorting#779
OCA-git-bot merged 1 commit into
OCA:18.0from
florentx:18.0_channeljob_enhanced

Conversation

@florentx

Copy link
Copy Markdown
Contributor

Experimental

  • Store the sorting key on the ChannelJob instance, to sort more efficiently.
  • Simplifiy __lt__ implementation.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@florentx

Copy link
Copy Markdown
ContributorAuthor

Coverage lowered because Doctests are not run:

Comment threadqueue_job/jobrunner/channels.py Outdated
@florentx
florentxforce-pushed the 18.0_channeljob_enhanced branch from 7144493 to c7620d1CompareJune 3, 2025 13:29
@florentx
florentx marked this pull request as ready for review June 3, 2025 16:22
@florentx
florentxforce-pushed the 18.0_channeljob_enhanced branch from c7620d1 to 19c1637CompareJune 3, 2025 16:25
@guewen

Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-779-by-guewen-bump-patch, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at cc6a746. Thanks a lot for contributing to OCA. ❤️

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@florentx@OCA-git-bot@guewen@sbidoul