Uh oh!
There was an error while loading. Please reload this page.
[18.0][IMP] queue_job: take weaker locks - #873
Merged
Merged
Conversation
Since we are not going to delete records nor modify foreign keys, we can take a weaker lock.
OCA-git-bot
commented
Jan 4, 2026
Contributor
Hi @guewen, |
guewen
approved these changes
Jan 4, 2026
RyanTranAVB
approved these changes
Jan 5, 2026
sbidoul
commented
Jan 5, 2026
MemberAuthor
/ocabot merge patch |
OCA-git-bot
commented
Jan 5, 2026
Contributor
This PR looks fantastic, let's merge it! |
OCA-git-bot
commented
Jan 5, 2026
Contributor
Congratulations, your PR was merged at 7ba8b45. Thanks a lot for contributing to OCA. ❤️ |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are not going to delete records nor modify foreign keys, we can take a weaker lock.
See for instance this article which explains why FOR UPDATE is usually a lock that is too strong.