Skip to content

[16.0][BP][IMP] queue_job: prevent commit during queue job execution - #881

Merged
OCA-git-bot merged 1 commit into
OCA:16.0from
acsone:16.0-prevent-commit-in-jobs
Feb 17, 2026
Merged

[16.0][BP][IMP] queue_job: prevent commit during queue job execution#881
OCA-git-bot merged 1 commit into
OCA:16.0from
acsone:16.0-prevent-commit-in-jobs

Conversation

@sbejaoui

@sbejaouisbejaoui commented Jan 21, 2026•
edited by sbidoul
Loading

Copy link
Copy Markdown
Contributor

Backport of #880
See also discussion in #889

@OCA-git-bot

OCA-git-bot commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@sbejaoui
sbejaoui marked this pull request as draft January 21, 2026 13:46
@sbejaoui
sbejaouiforce-pushed the 16.0-prevent-commit-in-jobs branch from 0f1bd2d to ba0e8a8CompareJanuary 23, 2026 10:29
@sbidoulsbidoul changed the title [BP][IMP] queue_job: prevent commit during queue job execution[16.0][BP][IMP] queue_job: prevent commit during queue job executionFeb 10, 2026
@sbidoul
[IMP] queue_job: prevent commit during queue job execution
ffee68b
This would release the job lock, causing spurious restarts by the dead jobs requeuer.
@sbidoul
sbidoulforce-pushed the 16.0-prevent-commit-in-jobs branch from ba0e8a8 to ffee68bCompareFebruary 10, 2026 15:00
@sbidoul
sbidoul marked this pull request as ready for review February 10, 2026 15:22
@sbidoul

sbidoul commented Feb 17, 2026

Copy link
Copy Markdown
Member

/ocabot merge minor

@OCA-git-bot

OCA-git-bot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-881-by-sbidoul-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 17, 2026
@OCA-git-bot
Merge PR#881into 16.0
c6f54a1
Signed-off-by sbidoul
@OCA-git-bot

OCA-git-bot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

@sbidoul your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-881-by-sbidoul-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

1 similar comment
@OCA-git-bot

OCA-git-bot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

@sbidoul your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-881-by-sbidoul-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@sbidoul

sbidoul commented Feb 17, 2026

Copy link
Copy Markdown
Member

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-881-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit be5500c into OCA:16.0Feb 17, 2026
5 of 7 checks passed
@OCA-git-bot

OCA-git-bot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 0fb76fb. Thanks a lot for contributing to OCA. ❤️

@sbidoul
sbidoul deleted the 16.0-prevent-commit-in-jobs branch February 17, 2026 16:33
@juliocabrerizojuliocabrerizo mentioned this pull request Feb 19, 2026
Open
@sebalixsebalix mentioned this pull request Mar 27, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbejaoui@OCA-git-bot@sbidoul