Uh oh!
There was an error while loading. Please reload this page.
[18.0][FIX] Adapt queue_job_profiler to job aquisition refactor - #941
Conversation
OCA-git-bot
commented
Jun 4, 2026
Hi @simahawk, |
amh-mw
left a comment
There was a problem hiding this comment.
Code review only, LGTM. Bonus points still available for a unit test that would have noticed the method signature change.
simahawk
commented
Jun 4, 2026
@TDu can you try to add the test? ? |
Broken by job acquisition refactoring OCA#941
c5e8590 to
ffa8ca2CompareTDu
commented
Jun 5, 2026
About adding a test that would have cached the change and make the module fail. I agree it would have been good to have one, but I am not sure of the pertinence of adding it afterwards. But I have updated the tests to use the RunJobController class and not an instance of it. queue/queue_job/controllers/main.py Line 108 in 1164f05 |
Broken by job acquisition refactoring OCA#941
ffa8ca2 to
ccef05cComparesimahawk
commented
Jun 5, 2026
/ocabot merge patch |
OCA-git-bot
commented
Jun 5, 2026
Hey, thanks for contributing! Proceeding to merge this for you. |
Uh oh!
There was an error while loading. Please reload this page.
OCA-git-bot
commented
Jun 5, 2026
Congratulations, your PR was merged at 71220ea. Thanks a lot for contributing to OCA. ❤️ |
That module was develop before this change
The new module tests were not affected by the change when merging.