[10.0][MIG] bi_view_editor: Port BI View Editor to V10 - #106
Conversation
pankk
left a comment
There was a problem hiding this comment.
Tested on runbot by creating a BI view. Ran into a javascript error (string of undefined), but clicked it away too fast and wasn't able to reproduce this error. For reference: I got this error when going to the pivot view from the pie view.
|
Can you maybe squash a bit the commits? |
|
In a quick test, I see that tables are always joined with |
|
@pedrobaeza yes, is possible. The initial idea behind this module is to keep the usability very simple, so adding a checkbox or a select to choose the type of join shouldn't be a problem. The potentials of this module are a lot, so we can add many other features, but then the actual user interface starts to show its limits. It would be nice to implement a more advanced UI, unfortunately I never had enough time for it. |
|
Please add it to the roadmap then, but I would use |
|
Rebased and squashed a bit |
LoisRForgeFlow
left a comment
There was a problem hiding this comment.
Functional review LGTM 👍
|
@astirpe Maybe I'm lucky... 😄 have you ever migrated using OpenUpgrade a database with this module? I'm facing some issues at the very beginning loading registry cause of this module. |
|
@lreficent are you talking about V8? Anyway I never migrated databases with this module. Uninstalling and installing again doesn't help? |
|
my advice is to uninstall in the original version and re-install in the new version. |
|
@astirpe @jbeficent yes, maybe that's the easiest. Thanks! |
yung-wang
left a comment
There was a problem hiding this comment.
Tested on runbot. I created a simple view consisting of the partner and country tabel. Please merge,
Based on the porting made for V9 #59