10.0 report qweb pdf watermark - #126
Conversation
|
@hbrunn is it a known issue that the watermark is not visible under the text in the report as in this example?
|
|
@StefanRijnhart no, in 9, this works. Does something set a background here? Or is https://github.com/OCA/OCB/blob/10.0/addons/report/static/src/css/reset.min.css not used for some reason? |
|
@hbrunn thanks for the pointer! This is actually reproducible on the 9.0 runbot. I'm guessing it's the background: transparent property from that css file that does the trick? |
|
@hbrunn What a minefield. Probably related to wkhtmltopdf/wkhtmltopdf#2084. Works with wkhtmltopdf 0.12.4 (instead of 0.12.2.4) and loading order of report.assets_pdf.0.css and report.assets_common.0.css reversed (the pdf one last, as it includes the reset CSS). |
|
nice catch! |
|
nice module! |
pedrobaeza
left a comment
There was a problem hiding this comment.
Please squash together all "OCA Transbot" commits (https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests)
61ea2c1 to
5827f05
Compare
|
@pedrobaeza you got it! |
pedrobaeza
left a comment
There was a problem hiding this comment.
Thanks! Let's wait for the Odoo's answer before merging this with the hack
5827f05 to
e928afd
Compare
|
I replaced the workaround for odoo/odoo#16610 with the fix that I also proposed to Odoo as per discussion on the upstream bug. |
e928afd to
d050269
Compare
d050269 to
f5171d6
Compare
|
@pedrobaeza @StefanRijnhart Can we merge this one? |
|
@lmignon Why, yes! |
Actual migration in this commit: StefanRijnhart@58e717a
Only functional change is that I removed the technical settings group tag (i.e. debug mode) on the expression field, because it is not possible to edit reports anyway without entering debug mode in the first place.
cc @hbrunn