Skip to content

[8.0] Add tree view and manage datetime of last materialized view refreshment - #150

Merged
legalsylvain merged 1 commit into
OCA:8.0from
grap:8.0_IMP_bi_sql_editor
Aug 1, 2018
Merged

legalsylvain merged 1 commit into
OCA:8.0from
grap:8.0_IMP_bi_sql_editor

Conversation

@legalsylvain

@legalsylvain legalsylvain commented Jul 14, 2017

Copy link
Copy Markdown
Contributor
  • ADD tree view management. courtesy @jbeficent. https://twitter.com/jbeficent_erp/status/885587899424681986

  • ADD datetime of the last refresh of the materialized view

  • improve fr translation

  • improve display of list of view, displaying color depending of the state of the view. (blue = draft, etc..)

Supersed #149

@legalsylvain
legalsylvain force-pushed the 8.0_IMP_bi_sql_editor branch from f8a8357 to 6aae22f Compare July 14, 2017 14:19
@legalsylvain legalsylvain added this to the 8.0 milestone Jul 14, 2017
@legalsylvain legalsylvain changed the title wip [8.0] Add tree view and manage datetime of last materialized view refreshment Jul 14, 2017
'search_view_id': self.search_view_id.id,
'view_type': 'graph',
'view_mode': 'graph',
'view_type': 'form',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking from me but 'view_type' is no more required/used: it works without it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @bealdav, view_type is used until last branches. (V10).
https://github.com/odoo/odoo/blob/10.0/odoo/addons/base/ir/ir_actions.py#L295
but yes, view_type has a default value to 'form'.

I propose to keep this code, and better to make a batch to remove globally, all that useless keys, in all OCA repository.

regards.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the precision

@AaronHForgeFlow AaronHForgeFlow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@legalsylvain
legalsylvain force-pushed the 8.0_IMP_bi_sql_editor branch 3 times, most recently from fa735ba to 9b8fea6 Compare June 27, 2018 09:25
[IMP] fr translation
[IMP] add last refresh date time on the action name of each sql materialized view
@legalsylvain
legalsylvain force-pushed the 8.0_IMP_bi_sql_editor branch from 9b8fea6 to 8c5840f Compare June 27, 2018 12:54
@legalsylvain

Copy link
Copy Markdown
Contributor Author

merging. (2 👍 and working on production).

@legalsylvain
legalsylvain merged commit a13762f into OCA:8.0 Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants