[11.0] [MIG] report_xlsx - #171
Conversation
…s to print to the 'create_xlsx_report' method + Instanciate the parser and make it available for the 'generate_xlsx_report' method
[MIG] Migration of report_xlsx to 10.0
…A#98) * Allow to define options for workbook creation
|
@etobella, very nice job! I was having really hard times migrating this module. I shure would get there, but it would take at least until the end of the week. |
|
@gabrielcardoso21 please review then the PR. @etobella any chance of increasing test coverage? |
bc13867 to
068e6fb
Compare
|
@pedrobaeza Test coverage improved, but controllers are not being tested right now. |
| Contributors | ||
| ------------ | ||
|
|
||
| * Adrien Peiffer <adrien.peiffer@acsone.eu> |
There was a problem hiding this comment.
I would suggest that you add your name as contributor
| @@ -0,0 +1,7 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # Copyright 2015 ACSONE SA/NV (<http://acsone.eu>) | |||
There was a problem hiding this comment.
be consistent and remove the copyright notice in all init files
There was a problem hiding this comment.
You can remove also coding line
There was a problem hiding this comment.
@elicoidal Suggested changes have been included.
There was a problem hiding this comment.
@pedrobaeza coding could be removed from all files, isn't it?
There was a problem hiding this comment.
Yeah, exactly. See second point of https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0#tasks-to-do-in-the-migration
9cac5c7 to
23f252b
Compare
elicoidal
left a comment
There was a problem hiding this comment.
js and xml can/should contain copyright notices too.
Not blocking for that though
| @@ -0,0 +1,3 @@ | |||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). | |||
23f252b to
692da64
Compare
Migration to 11.0.
Creation of reports has changed a little because report_swx has disappeared on v11. However, changes are not complicated.