Skip to content

[IMP] report_fillpdf, report_xlsx, report_xml: Use content_disposition helper #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedrobaeza merged 1 commit into from
Mar 19, 2018
Merged

[IMP] report_fillpdf, report_xlsx, report_xml: Use content_disposition helper #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion report_fillpdf/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
'Odoo Community Association (OCA)',
'website': "http://github.com/oca/reporting-engine",
'category': 'Reporting',
'version': '11.0.1.0.0',
'version': '11.0.1.0.1',
'license': 'AGPL-3',
'external_dependencies': {
'python': [
Expand Down
4 changes: 2 additions & 2 deletions report_fillpdf/controllers/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# License AGPL-3.0 or later (https://www.gnuorg/licenses/agpl.html).

from odoo.addons.web.controllers import main as report
from odoo.http import route, request
from odoo.http import content_disposition, route, request

import json

Expand Down Expand Up @@ -34,7 +34,7 @@ def report_routes(self, reportname, docids=None, converter=None, **data):
('Content-Length', len(pdf)),
(
'Content-Disposition',
'attachment; filename=' + report.report_file + '.pdf'
content_disposition(report.report_file + '.pdf')
)
]
return request.make_response(pdf, headers=pdfhttpheaders)
Expand Down
2 changes: 1 addition & 1 deletion report_xlsx/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
'Odoo Community Association (OCA)',
'website': "http://github.com/oca/reporting-engine",
'category': 'Reporting',
'version': '11.0.1.0.0',
'version': '11.0.1.0.1',
'license': 'AGPL-3',
'external_dependencies': {
'python': [
Expand Down
4 changes: 2 additions & 2 deletions report_xlsx/controllers/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# License AGPL-3.0 or later (https://www.gnuorg/licenses/agpl.html).

from odoo.addons.web.controllers import main as report
from odoo.http import route, request
from odoo.http import content_disposition, route, request

import json

Expand Down Expand Up @@ -35,7 +35,7 @@ def report_routes(self, reportname, docids=None, converter=None, **data):
('Content-Length', len(xlsx)),
(
'Content-Disposition',
'attachment; filename=' + report.report_file + '.xlsx'
content_disposition(report.report_file + '.xlsx')
)
]
return request.make_response(xlsx, headers=xlsxhttpheaders)
Expand Down
2 changes: 1 addition & 1 deletion report_xml/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

{
"name": "XML Reports",
"version": "11.0.1.0.0",
"version": "11.0.1.0.1",
"category": "Reporting",
"website": "https://github.com/OCA/reporting-engine",
"author": "Grupo ESOC Ingeniería de Servicios, "
Expand Down
4 changes: 2 additions & 2 deletions report_xml/controllers/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# License AGPL-3.0 or later (https://www.gnuorg/licenses/agpl.html).

from odoo.addons.web.controllers import main as report
from odoo.http import route
from odoo.http import content_disposition, route


class ReportController(report.ReportController):
Expand All @@ -23,5 +23,5 @@ def report_routes(self, reportname, docids=None, converter=None, **data):
response.headers.set('Content-length', len(response.data))
response.headers.set(
'Content-Disposition',
'attachment; filename="'+reportname+".xml")
content_disposition(reportname + ".xml"))
return response