Skip to content

[MIG] report_qweb_signer: Migration to 12.0 - #253

Merged
pedrobaeza merged 13 commits into
OCA:12.0from
Tecnativa:12.0-mig-report_qweb_signer
May 16, 2019
Merged

[MIG] report_qweb_signer: Migration to 12.0#253
pedrobaeza merged 13 commits into
OCA:12.0from
Tecnativa:12.0-mig-report_qweb_signer

Conversation

@chienandalu

@chienandalu chienandalu commented Nov 13, 2018

Copy link
Copy Markdown
Member

This module extends the functionality of report module to sign
PDFs using a PKCS#12 certificate.

cc @Tecnativa

@pedrobaeza pedrobaeza changed the title [MIG] report_qweb_designer: Migration to 12.0 [MIG] report_qweb_signer: Migration to 12.0 Nov 13, 2018
@pedrobaeza pedrobaeza added this to the 12.0 milestone Nov 13, 2018
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 13, 2018
Closed
16 tasks
@pedrobaeza

pedrobaeza commented Nov 13, 2018

Copy link
Copy Markdown
Member

Please check tests failure and runbot warning:

2018-11-13 09:49:28,314 152 WARNING openerp_test odoo.models: The model report.certificate has no _description

@chienandalu

chienandalu commented Nov 19, 2018

Copy link
Copy Markdown
Member Author

I have the tests failing on java's memory: https://travis-ci.org/OCA/reporting-engine/jobs/454946302#L783 Any travis configurations needed?

@pedrobaeza

pedrobaeza commented Nov 19, 2018

Copy link
Copy Markdown
Member

I'm trying one possible patch.

@pedrobaeza

pedrobaeza commented Nov 19, 2018

Copy link
Copy Markdown
Member

No luck. @yajo do you guess something?

yajo
yajo reviewed Nov 19, 2018
View reviewed changes
Comment thread report_qweb_signer/data/defaults.xml
@chienandalu
chienandalu force-pushed the 12.0-mig-report_qweb_signer branch from 79f97c4 to feb8562 Compare November 19, 2018 12:54
@chienandalu

chienandalu commented Nov 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

@yajo Still the same: https://travis-ci.org/OCA/reporting-engine/jobs/456961880#L783

@yajo

yajo commented Nov 20, 2018

Copy link
Copy Markdown
Member

You can try adding this to .travis.yml, as explained in travis-ci/travis-ci#8408:

before_script:
  - _JAVA_OPTIONS=

@chienandalu

chienandalu commented Nov 20, 2018

Copy link
Copy Markdown
Member Author

Thanks @yajo let's try that.

@chienandalu

chienandalu commented Nov 20, 2018

Copy link
Copy Markdown
Member Author

Nay 😞

@yajo

yajo commented Nov 20, 2018

Copy link
Copy Markdown
Member

Could you try ideas from https://stackoverflow.com/a/33794801/1468388?

You could try running ulimit -v or similar inside Travis to know its limits...

antespi and others added 12 commits May 14, 2019 20:07
@antespi @pedrobaeza
report_qweb_signer addon
df96442
@pedrobaeza
report_qweb_signer: Add feature request
55a244d
@oca-transbot @pedrobaeza
OCA Transbot updated translations from Transifex
9359415
@pedrobaeza
[MIG] report_qweb_signer: Migration to 10.0
97f9aba
@oca-transbot @pedrobaeza
OCA Transbot updated translations from Transifex
7b31883
@JordiBForgeFlow @pedrobaeza
fix test_report_qweb_signer - tests were causing travis to stall
8db0c51
@yajo @pedrobaeza
[FIX] report_qweb_signer: Remove hardcoded memory limits
10276de 
These limits were being hit when printing PDF reports with just 80 pages.
@oca-transbot @pedrobaeza
OCA Transbot updated translations from Transifex
e614522
@oca-travis @pedrobaeza
[UPD] Update report_qweb_signer.pot
7c4219e
@pedrobaeza
[FIX] README syntax
523a270
@chienandalu @pedrobaeza
[MIG] report_qweb_designer: Migration to 12.0
c65a394
@pedrobaeza
.travis.yml: Adapt to latest standard + add variable for JavaVM error
ef5a6bf 
Avoid error:

Error occurred during initialization of VM
Could not allocate metaspace: 1073741824 bytes

trying solution proposed in https://stackoverflow.com/a/33794801
@pedrobaeza
pedrobaeza force-pushed the 12.0-mig-report_qweb_signer branch from 412db04 to ef5a6bf Compare May 14, 2019 18:10
@pedrobaeza
[MIG] report_qweb_signer: Refine migration
6e462b2 
- Good dependency chain
- Context for forcing rendering PDF
- Extra test
@pedrobaeza
pedrobaeza force-pushed the 12.0-mig-report_qweb_signer branch from 0eb61c5 to 6e462b2 Compare May 16, 2019 12:11
@pedrobaeza

pedrobaeza commented May 16, 2019

Copy link
Copy Markdown
Member

Merging as it's finally green

@pedrobaeza
pedrobaeza merged commit b3621c0 into OCA:12.0 May 16, 2019
@pedrobaeza
pedrobaeza deleted the 12.0-mig-report_qweb_signer branch May 16, 2019 13:34
@etobella

etobella commented May 16, 2019

Copy link
Copy Markdown
Member

Just a question, I found a python library that could sign documents:
https://github.com/m32/endesive
Maybe we could check if we can replace the java. What do you think?

@pedrobaeza

pedrobaeza commented May 16, 2019

Copy link
Copy Markdown
Member

Well, this is working fine since a lot, so although Java is not my favorite one, unless this is proven to be work painless, I won't switch. We can try on the CS.

@etobella

etobella commented May 16, 2019

Copy link
Copy Markdown
Member

Ok, we will check it there 😉

@chienandalu

chienandalu commented May 16, 2019

Copy link
Copy Markdown
Member Author

Hi, @etobella Yes, I discarded to try it because the project seemed to be a little immature yet. There was no much feedback or documentation around so adopting it seemed a little bit risky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yajo yajo yajo left review comments
@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees

No one assigned

Labels

needs review

Projects

None yet

Milestone

12.0

Development

Successfully merging this pull request may close these issues.

8 participants

@chienandalu @pedrobaeza @yajo @etobella @antespi @oca-transbot @JordiBForgeFlow @oca-travis