Skip to content

[12.0][MIG] report_wkhtmltopdf_param - #278

Merged
pedrobaeza merged 6 commits into
OCA:12.0from
Studio73:12.0-report_wkhtmltopdf_param
Jun 6, 2019
Merged

pedrobaeza merged 6 commits into
OCA:12.0from
Studio73:12.0-report_wkhtmltopdf_param

Conversation

@Abranes

@Abranes Abranes commented Mar 28, 2019

Copy link
Copy Markdown
Member

Standard migration to 12.0

cc @Jortolsa @fuentes010 @ioans73 @Saphery @Willerr-mo

@gdgellatly

Copy link
Copy Markdown
Contributor

@Abranes there is no way to delete a custom setting logged in as admin user or any user for that matter. I don't think it should be necessary to Become SuperUser to delete a setting. Otherwise tested and works.

@gustavovalverde

Copy link
Copy Markdown
Member

@Abranes tested and working. Could you make the fix exposed by @gdgellatly so we can proceed with some approval love? 😄

@andres-pcg

Copy link
Copy Markdown

@Abranes nice and tidy, could you make the change suggested by @gdgellatly? it would be nice to have checks printing functionality on v12. Thanks in advance.

@andres-pcg

Copy link
Copy Markdown

Any updates on this one ?

@Abranes
Abranes force-pushed the 12.0-report_wkhtmltopdf_param branch from 932377b to dd1d521 Compare June 3, 2019 08:50
@oca-clabot

Copy link
Copy Markdown

Hey @Abranes, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@Abranes

Abranes commented Jun 3, 2019

Copy link
Copy Markdown
Member Author

Hello, sorry for the late response.
@gdgellatly I added a new access rule for Administration/Settings to give permission to them to delete a setting.

I don't know what happen with @oca-clabot because I signed the CLA, anyone can review?

@gdgellatly

Copy link
Copy Markdown
Contributor

@Abranes don't worry about CLA. It happens due to historic commits on migrated modules.

Comment thread report_wkhtmltopdf_param/security/ir.model.access.csv Outdated
@Abranes
Abranes force-pushed the 12.0-report_wkhtmltopdf_param branch from dd1d521 to 46ccecb Compare June 4, 2019 06:40
@andres-pcg

Copy link
Copy Markdown

Hey so this is ready @pedrobaeza , thanks

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
pedrobaeza merged commit 980d7b4 into OCA:12.0 Jun 6, 2019
@Abranes
Abranes deleted the 12.0-report_wkhtmltopdf_param branch June 6, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.