[13.0][ADD] report_py3o_signer - #523
Closed
Laurent-Corron wants to merge 4 commits into
Closed
Laurent-Corron wants to merge 4 commits into
Laurent-Corron wants to merge 4 commits into
Conversation
Laurent-Corron
force-pushed
the
add-report_py3o_signer-lco
branch
2 times, most recently
from
July 2, 2021 08:34
5b794cc to
f79e6a1
Compare
Laurent-Corron
force-pushed
the
add-report_py3o_signer-lco
branch
from
July 19, 2021 13:56
f79e6a1 to
ab708a3
Compare
Member
|
@Laurent-Corron can you rebase ? |
sbidoul
reviewed
Jul 21, 2021
sbidoul
reviewed
Jul 21, 2021
sbidoul
reviewed
Jul 21, 2021
| ) | ||
| signed = self.pdf_sign(pdf, certificate) | ||
| # Read signed PDF | ||
| if os.path.exists(signed): |
Member
There was a problem hiding this comment.
Shouldn't we raise an exception if signed does not exist ?
Actually, is it possible for pdf_sign to return a nonexistent file ?
sbidoul
reviewed
Jul 21, 2021
sbidoul
reviewed
Jul 21, 2021
Member
|
Can you also add a DESCRIPTION.rst and minimal USAGE.rst ? |
Laurent-Corron
force-pushed
the
add-report_py3o_signer-lco
branch
2 times, most recently
from
July 23, 2021 13:00
f8d6b02 to
16404bf
Compare
sbidoul
reviewed
Jul 27, 2021
Laurent-Corron
force-pushed
the
add-report_py3o_signer-lco
branch
3 times, most recently
from
July 29, 2021 09:03
feeb090 to
8f5e016
Compare
ThomasBinsfeld
force-pushed
the
add-report_py3o_signer-lco
branch
from
September 10, 2021 08:06
8f5e016 to
34a34c6
Compare
ThomasBinsfeld
force-pushed
the
add-report_py3o_signer-lco
branch
from
October 14, 2021 10:18
3959a5f to
86284a6
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.