[14.0][MIG] report_qweb_signer by omar7r · Pull Request #534 · OCA/reporting-engine

omar7r · 2021-08-30T18:59:40Z

No description provided.

OCA Transbot updated translations from Transifex

These limits were being hit when printing PDF reports with just 80 pages. OCA Transbot updated translations from Transifex [UPD] Update report_qweb_signer.pot

- Good dependency chain - Context for forcing rendering PDF - Extra test [UPD] README.rst [UPD] Update report_qweb_signer.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_qweb_signer/ [UPD] README.rst

`render_qweb_pdf` must return a tuple of `(content, 'pdf')`

Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_qweb_signer/

Fix website on manifest

[UPD] Update report_qweb_signer.pot [UPD] README.rst

Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-13.0/reporting-engine-13.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-report_qweb_signer/

OCA-git-bot · 2021-08-30T18:59:46Z

Hi @omar7r! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the maintainers key of the addon manifest.

…isible signatures

chienandalu

Hi @omar7r please include #542

pedrobaeza · 2021-10-01T12:46:51Z

There has been also some moves in v13 version to add (and planning to switch to) a new Python library.

chienandalu · 2021-10-01T12:52:34Z

There has been also some moves in v13 version to add (and planning to switch to) a new Python library.

At the time I didn't find a library mature enough to stick to, although the current implementation isn't very neat anyway...

pedrobaeza · 2021-10-01T13:33:09Z

Please see #528. It seems this one is promising. @sbidoul how were your tests? Should we remove java library in favor of this one?

sbidoul · 2021-10-01T13:41:02Z

@pedrobaeza @chienandalu We have positive results so far with endesive but no large scale production feedback yet. So its probably premature to drop the java code yet.

chienandalu · 2021-10-01T13:42:20Z

Oh, yeah. That the one I had spotted but two years ago it was fairly new

pedrobaeza · 2021-10-01T13:43:38Z

Ok, then at least this PR should be updated with latest 13.0 commits

sbidoul · 2021-10-01T13:45:27Z

And there is also #533 that is pending.

We don't want our custom parameters be reset every time the module updates. TT32256

…default and fix multicompany issue

…objects (print from wizard in some cases)

pedrobaeza · 2021-11-15T19:52:29Z

@omar7r did you check about the new sign method? Travis is red by the way.

omar7r · 2021-11-16T10:55:30Z

Yes, I tested two options, both works fine. I think that Travis fails because needs to have installed the package swig in the system, where can I add it?

pedrobaeza · 2021-11-16T10:56:26Z

You can put it on requirements.txt file in the root folder.

pedrobaeza · 2021-11-16T10:56:47Z

Should we remove Java library then and leave only the Pythonic one?

chienandalu · 2021-11-16T10:58:26Z

Out of curiosity, how do both methods compare in performance when printing a big number of signed documents?

omar7r · 2021-11-16T11:11:33Z

Swig it's a dependency in the machine not at python level.

In our case, we are using java's library in production, because the project was a migration, from 10.0 to 14.0, I don't test the python library printing several invoices at time. I don't know if someone use the pythonic lib in production and could give feedback, if not, it will be a good test to do, before the decision.

pedrobaeza · 2021-11-16T11:21:50Z

Then you need to change .travis.yml to install such dependency:

https://github.com/OCA/reporting-engine/blob/13.0/.travis.yml#L15

ernestotejeda

On runbot:

ernestotejeda · 2022-02-15T13:48:09Z

Hello @omar7r , are you working on this PR? If not, I can supersede it to speed up the migration, thanks.

omar7r · 2022-02-16T09:09:55Z

Hi @ernestotejeda

Yes, but I didn't have much time since your comment, on friday I think I can review it.

omar7r · 2022-02-18T17:57:41Z

@ernestotejeda I tested it again locally and it works, maybe Runbot doesn't have enough memory for running Java.

chienandalu

Ok, perfect :) Can you squash the migration commits?

ernestotejeda

tested locally 👍🏼

pedrobaeza · 2022-02-21T14:51:23Z

/ocabot migration report_qweb_signer
/ocabot merge nobump

OCA-git-bot · 2022-02-21T14:51:42Z

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-534-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2022-02-21T15:04:23Z

Congratulations, your PR was merged at 945e958. Thanks a lot for contributing to OCA. ❤️

antespi and others added 18 commits August 30, 2021 13:24

report_qweb_signer addon

047cdad

report_qweb_signer: Add feature request

ba5030a

OCA Transbot updated translations from Transifex

[MIG] report_qweb_signer: Migration to 10.0

4ef450a

OCA Transbot updated translations from Transifex

fix test_report_qweb_signer - tests were causing travis to stall

f3a9d76

[FIX] report_qweb_signer: Remove hardcoded memory limits

69bc797

These limits were being hit when printing PDF reports with just 80 pages. OCA Transbot updated translations from Transifex [UPD] Update report_qweb_signer.pot

[FIX] README syntax

bd37d7e

[MIG] report_qweb_designer: Migration to 12.0

7c8cada

[IMP] report_qweb_signer: Black python code

b2b51f0

report_qweb_signer 13.0.1.0.1

c8c747d

[IMP] report_qweb_signer add endesive

225ef60

[UPD] Update report_qweb_signer.pot

08606f4

[FIX] report_qweb_signer: reprint report crash

b7cd36d

`render_qweb_pdf` must return a tuple of `(content, 'pdf')`

[FIX] report_qweb_signer

e9665dc

Fix website on manifest

[MIG] report_qweb_signer: Migration to 13.0

40dac0d

[UPD] Update report_qweb_signer.pot [UPD] README.rst

Apply dotfiles

61d32f2

[MIG] report_qweb_signer: Migration to 14.0 updating java's lib for v…

54bf4b0

…isible signatures

omar7r force-pushed the 14.0-mig-report_qweb_signer branch from 206f3b4 to 54bf4b0 Compare August 30, 2021 19:01

chienandalu reviewed Oct 1, 2021

View reviewed changes

[FIX] report_qweb_signer: noupdate defaults

629a76d

We don't want our custom parameters be reset every time the module updates. TT32256

omar7r added 2 commits November 2, 2021 19:07

[IMP] report_qweb_signer: Signature visible parameter not include by …

f697543

…default and fix multicompany issue

[FIX] report_qweb_signer: Fix when report is printed without related …

f93480f

…objects (print from wizard in some cases)

ernestotejeda reviewed Feb 7, 2022

View reviewed changes

Comment thread report_qweb_signer/models/ir_actions_report.py Outdated

ernestotejeda reviewed Feb 7, 2022

View reviewed changes

omar7r added 2 commits February 18, 2022 18:46

[UPD] Travis: swig

fde3c75

[FIX] report_qweb_signer: Handle multi-company correctly

849d8f1

omar7r force-pushed the 14.0-mig-report_qweb_signer branch from 1991b11 to 849d8f1 Compare February 18, 2022 17:48

chienandalu reviewed Feb 21, 2022

View reviewed changes

Comment thread .travis.yml

chienandalu approved these changes Feb 21, 2022

View reviewed changes

ernestotejeda approved these changes Feb 21, 2022

View reviewed changes

OCA-git-bot added the approved label Feb 21, 2022

OCA-git-bot added this to the 14.0 milestone Feb 21, 2022

OCA-git-bot mentioned this pull request Feb 21, 2022

Migration to version 14.0 #438

Closed

14 tasks

OCA-git-bot added the bot is merging ⏳ label Feb 21, 2022

OCA-git-bot merged commit 341c75b into OCA:14.0 Feb 21, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 21, 2022

Uh oh!

Conversation

omar7r commented Aug 30, 2021

Uh oh!

OCA-git-bot commented Aug 30, 2021

Uh oh!

chienandalu left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Oct 1, 2021

Uh oh!

chienandalu commented Oct 1, 2021

Uh oh!

pedrobaeza commented Oct 1, 2021

Uh oh!

sbidoul commented Oct 1, 2021

Uh oh!

chienandalu commented Oct 1, 2021

Uh oh!

pedrobaeza commented Oct 1, 2021

Uh oh!

sbidoul commented Oct 1, 2021

Uh oh!

pedrobaeza commented Nov 15, 2021

Uh oh!

omar7r commented Nov 16, 2021

Uh oh!

pedrobaeza commented Nov 16, 2021

Uh oh!

pedrobaeza commented Nov 16, 2021

Uh oh!

chienandalu commented Nov 16, 2021

Uh oh!

omar7r commented Nov 16, 2021

Uh oh!

pedrobaeza commented Nov 16, 2021

Uh oh!

Uh oh!

ernestotejeda left a comment

Choose a reason for hiding this comment

Uh oh!

ernestotejeda commented Feb 15, 2022

Uh oh!

omar7r commented Feb 16, 2022

Uh oh!

omar7r commented Feb 18, 2022

Uh oh!

Uh oh!

chienandalu left a comment

Choose a reason for hiding this comment

Uh oh!

ernestotejeda left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Feb 21, 2022

Uh oh!

OCA-git-bot commented Feb 21, 2022

Uh oh!

OCA-git-bot commented Feb 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants