[15.0][MIG] report_xlsx by JoanMForgeFlow · Pull Request #554 · OCA/reporting-engine

JoanMForgeFlow · 2021-12-07T11:39:16Z

standard migration of the module report_xlsx to version 15.0

JordiBForgeFlow · 2021-12-07T13:30:29Z

@ChrisOForgeFlow can you help with the js?

aisopuro · 2021-12-09T08:38:40Z

If it helps, I made an ugly solution in my migration of report_xml due to the report handler service being strictly private in version 15: https://github.com/OCA/reporting-engine/pull/550/files#diff-364e5c801ea1b16dac1cd54935f7851db3173417864b4bebb485b94c0bb6599eR6.

Hopefully that can help you with the JS. If you come up with a better solution than mine that could also be applied in report_xml, please ping me on that PR: I would love to be able to have a better solution 😅 .

JoanMForgeFlow · 2021-12-09T08:41:53Z

@ChrisOForgeFlow Thanks so much for your help! Its working :)

AaronHForgeFlow

It just works

JoanMForgeFlow · 2021-12-09T11:17:01Z

@lmignon, @alexis-via or @faide could you please merge this module? Thanks

… in selection

…s to print to the 'create_xlsx_report' method + Instanciate the parser and make it available for the 'generate_xlsx_report' method

…A#98) * Allow to define options for workbook creation

…n helper

* refactor: On new ActionManager override _makeReportUrls and triggerDownload to support XLSX format * pass action to custom _downloadReportXLSX: Need action to get report data * dict constructor to remove context lang

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Currently translated at 88.2% (15 of 17 strings) Translation: reporting-engine-12.0/reporting-engine-12.0-report_xlsx Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xlsx/de/

Currently translated at 94.4% (17 of 18 strings) Translation: reporting-engine-12.0/reporting-engine-12.0-report_xlsx Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xlsx/pt/

Currently translated at 92.3% (12 of 13 strings) Translation: reporting-engine-14.0/reporting-engine-14.0-report_xlsx Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-report_xlsx/sv/

LoisRForgeFlow · 2021-12-10T10:02:59Z

/ocabot merge nobump

OCA-git-bot · 2021-12-10T10:03:25Z

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-554-by-LoisRForgeFlow-bump-nobump, awaiting test results.

Signed-off-by LoisRForgeFlow

OCA-git-bot · 2021-12-10T10:07:22Z

@LoisRForgeFlow your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-554-by-LoisRForgeFlow-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

LoisRForgeFlow · 2021-12-10T10:54:20Z

Cache issue again in pre-commit.

@sbidoul Do you have a way to easily invalidate the cache of pre-commit jobs?

If not, we just need to wait a couple of days to try again the merge.

AaronHForgeFlow · 2021-12-10T16:16:39Z

/ocabot migration report_xlsx

OCA-git-bot · 2021-12-10T16:16:57Z

Sorry @AaronHForgeFlow you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

pedrobaeza · 2021-12-11T11:21:50Z

Trusting on reviews:

/ocabot migration report_xlsx

/ocabot merge nobump

OCA-git-bot · 2021-12-11T11:21:59Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-554-by-pedrobaeza-bump-nobump, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2021-12-11T11:25:24Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-554-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza · 2021-12-11T11:26:53Z

It seems the problem with cached pre-commit is still there. Merging manually for now as no version bump is required.

BT-ojossen · 2022-01-10T15:09:31Z

Hello @JoanMForgeFlow, could it be that with this module installed, the default creation of a pdf is not working anymore?
Thanks for having a look.

AaronHForgeFlow · 2022-01-10T16:03:51Z

@BT-ojossen if you uninstall this module is the default creation of pdf working? are you using enterprise version or community?

BT-ojossen · 2022-01-10T16:06:37Z

@JoanMForgeFlow
Yes, when I uninstall the module, the pdf creation is working. I'm using enterprise.

AaronHForgeFlow · 2022-01-10T16:20:35Z

That seems something to investigate, I originally tested this in community version only.

BT-ojossen · 2022-01-26T08:02:56Z

Hi @AaronHForgeFlow
Thanks for your answer. Would it be possible that you have a look at this issue as you know best what you already did.
Thanks a lot.

JoanMForgeFlow mentioned this pull request Dec 9, 2021

[15.0][MIG] mrp_flattened_bom_xlsx OCA/manufacture-reporting#90

Merged

AaronHForgeFlow approved these changes Dec 9, 2021

View reviewed changes

mariadforgeflow approved these changes Dec 9, 2021

View reviewed changes

OCA-git-bot added the approved label Dec 9, 2021

Adrien Peiffer (ACSONE) and others added 22 commits December 10, 2021 10:12

[CHG] Rename base_report_xlsx to report_xlsx and add xlsx report type…

69536c2

… in selection

[IMP] report_xlsx - Pass the report instance as well as ids of record…

351e558

…s to print to the 'create_xlsx_report' method + Instanciate the parser and make it available for the 'generate_xlsx_report' method

[MIG] Migration of report_xlsx to 10.0 (OCA#76)

90729b2

[10.0] report_xlsx: Allow to define options for workbook creation (OC…

b920fad

…A#98) * Allow to define options for workbook creation

OCA Transbot updated translations from Transifex

6896c73

[MIG] report_xlsx: Migration to 11.0

f0455b7

OCA Transbot updated translations from Transifex

5f4a5b4

[IMP] report_fillpdf, report_xlsx, report_xml: Use content_dispositio…

31825ca

…n helper

[UPD] Update report_xlsx.pot

9387e88

Fix report_xlsx for printing from wizards

2842f2a

[MIG] report_xlsx: Migration to 12.0

98379af

* refactor: On new ActionManager override _makeReportUrls and triggerDownload to support XLSX format * pass action to custom _downloadReportXLSX: Need action to get report data * dict constructor to remove context lang

[IMP] report_xlsx: README by fragments

5d1f93b

[UPD] Update report_xlsx.pot

2cc2847

Update translation files

39eef0c

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Translated using Weblate (German)

e00edf7

Currently translated at 88.2% (15 of 17 strings) Translation: reporting-engine-12.0/reporting-engine-12.0-report_xlsx Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xlsx/de/

[UPD] README.rst

34abd0a

[12.0][IMP] report_xlsx, make sure print_report_name works

b8d7bf5

Added translation using Weblate (Portuguese)

efbb643

Translated using Weblate (Portuguese)

70b7f3d

Currently translated at 94.4% (17 of 18 strings) Translation: reporting-engine-12.0/reporting-engine-12.0-report_xlsx Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xlsx/pt/

report_xlsx 12.0.1.0.1

d69546f

[MIG] report_xlsx: Migration to 13.0

70ad9af

[MIG][IMP][13.0] rebase to include new linters

67ecf5c

simonstromb and others added 3 commits December 10, 2021 10:12

Translated using Weblate (Swedish)

8ca53e0

Currently translated at 92.3% (12 of 13 strings) Translation: reporting-engine-14.0/reporting-engine-14.0-report_xlsx Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-report_xlsx/sv/

[MIG] report_xlsx: Migration to 15.0

fee3183

[FIX] report_xlsx: refactor controller and report hamdler

bc9203a

LoisRForgeFlow force-pushed the 15.0-mig-report_xlsx branch from 036de4d to bc9203a Compare December 10, 2021 10:01

LoisRForgeFlow approved these changes Dec 10, 2021

View reviewed changes

OCA-git-bot added a commit that referenced this pull request Dec 10, 2021

Merge PR #554 into 15.0

fc08788

Signed-off-by LoisRForgeFlow

OCA-git-bot added the bot is merging ⏳ label Dec 10, 2021

OCA-git-bot removed the bot is merging ⏳ label Dec 10, 2021

OCA-git-bot added this to the 15.0 milestone Dec 11, 2021

OCA-git-bot mentioned this pull request Dec 11, 2021

Migration to version 15.0 #545

Closed

20 tasks

OCA-git-bot added the bot is merging ⏳ label Dec 11, 2021

OCA-git-bot added a commit that referenced this pull request Dec 11, 2021

Merge PR #554 into 15.0

d4dfac7

Signed-off-by pedrobaeza

OCA-git-bot removed the bot is merging ⏳ label Dec 11, 2021

pedrobaeza merged commit a94fb9d into OCA:15.0 Dec 11, 2021

LoisRForgeFlow deleted the 15.0-mig-report_xlsx branch December 13, 2021 07:38

Uh oh!

Conversation

JoanMForgeFlow commented Dec 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JordiBForgeFlow commented Dec 7, 2021

Uh oh!

aisopuro commented Dec 9, 2021

Uh oh!

JoanMForgeFlow commented Dec 9, 2021

Uh oh!

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

JoanMForgeFlow commented Dec 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LoisRForgeFlow commented Dec 10, 2021

Uh oh!

OCA-git-bot commented Dec 10, 2021

Uh oh!

OCA-git-bot commented Dec 10, 2021

Uh oh!

LoisRForgeFlow commented Dec 10, 2021

Uh oh!

AaronHForgeFlow commented Dec 10, 2021

Uh oh!

OCA-git-bot commented Dec 10, 2021

Uh oh!

pedrobaeza commented Dec 11, 2021

Uh oh!

OCA-git-bot commented Dec 11, 2021

Uh oh!

OCA-git-bot commented Dec 11, 2021

Uh oh!

pedrobaeza commented Dec 11, 2021

Uh oh!

BT-ojossen commented Jan 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AaronHForgeFlow commented Jan 10, 2022

Uh oh!

BT-ojossen commented Jan 10, 2022

Uh oh!

AaronHForgeFlow commented Jan 10, 2022

Uh oh!

BT-ojossen commented Jan 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

JoanMForgeFlow commented Dec 7, 2021 •

edited

Loading

JoanMForgeFlow commented Dec 9, 2021 •

edited

Loading

BT-ojossen commented Jan 10, 2022 •

edited

Loading