Skip to content

[IMP] kpi_dashboard: Allow to set a specific context for a KPI - #576

Merged
OCA-git-bot merged 1 commit into
OCA:14.0from
tegin:14.0-imp-kpi-dashboard
May 4, 2022
Merged

[IMP] kpi_dashboard: Allow to set a specific context for a KPI#576
OCA-git-bot merged 1 commit into
OCA:14.0from
tegin:14.0-imp-kpi-dashboard

Conversation

@olgamarcocb

@olgamarcocb olgamarcocb commented Jan 12, 2022

Copy link
Copy Markdown

Adding cherry-pick #575

albariera
albariera approved these changes May 3, 2022
View reviewed changes

@albariera albariera left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@etobella

etobella commented May 3, 2022

Copy link
Copy Markdown
Member

/ocabot merge minor

@OCA-git-bot

OCA-git-bot commented May 3, 2022

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-576-by-etobella-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 3, 2022
@OCA-git-bot
Merge PR #576 into 14.0
e0ef37e 
Signed-off-by etobella
@OCA-git-bot

OCA-git-bot commented May 3, 2022

Copy link
Copy Markdown
Contributor

@etobella your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-576-by-etobella-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@etobella etobella mentioned this pull request May 3, 2022
Closed
@olgamarcocb
olgamarcocb force-pushed the 14.0-imp-kpi-dashboard branch from ee2fde1 to 2d45b0f Compare May 4, 2022 07:41
@etobella

etobella commented May 4, 2022

Copy link
Copy Markdown
Member

Something is happening with the container. It seems is not being updated:
https://github.com/OCA/oca-ci/runs/6284155668?check_suite_focus=true

@sbidoul

@etobella

etobella commented May 4, 2022

Copy link
Copy Markdown
Member

/ocabot merge minor

@OCA-git-bot

OCA-git-bot commented May 4, 2022

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-576-by-etobella-bump-minor, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit c41e86d into OCA:14.0 May 4, 2022
@OCA-git-bot

OCA-git-bot commented May 4, 2022

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at bc77438. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etobella etobella etobella approved these changes
+1 more reviewer
@albariera albariera albariera approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@olgamarcocb @etobella @OCA-git-bot @albariera