Skip to content

[15.0][MIG] report_qweb_element_page_visibility: Migrate to version 15.0 - #634

Merged
OCA-git-bot merged 22 commits into
OCA:15.0from
hailangvn:15.0-mig-report_qweb_element_page_visibility
Dec 21, 2022
Merged

OCA-git-bot merged 22 commits into
OCA:15.0from
hailangvn:15.0-mig-report_qweb_element_page_visibility

Conversation

@hailangvn

Copy link
Copy Markdown
Contributor

No description provided.

@hailangvn hailangvn mentioned this pull request Jul 5, 2022
20 tasks
Sebastien LANGE and others added 21 commits July 5, 2022 15:36
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: reporting-engine-14.0/reporting-engine-14.0-report_qweb_element_page_visibility
Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-report_qweb_element_page_visibility/
@hailangvn
hailangvn force-pushed the 15.0-mig-report_qweb_element_page_visibility branch from a232906 to 69d7f2e Compare July 5, 2022 08:36
@hailangvn
hailangvn marked this pull request as ready for review July 5, 2022 09:10
@hailangvn hailangvn changed the title [14.0][MIG] report_qweb_element_page_visibility: Migrate to version 14.0 [15.0][MIG] report_qweb_element_page_visibility: Migrate to version 15.0 Jul 5, 2022
@leemannd

Copy link
Copy Markdown
Contributor

Hello @hailangvn Could you have a look at the pre-commit?

@yvaucher yvaucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo in a loop uses an index instead of the value which looks suspicious.
Otherwise LGTM

Comment thread report_qweb_element_page_visibility/views/layouts.xml
@hailangvn
hailangvn force-pushed the 15.0-mig-report_qweb_element_page_visibility branch 3 times, most recently from 69d7f2e to 6125aa5 Compare July 15, 2022 03:08
@hailangvn
hailangvn force-pushed the 15.0-mig-report_qweb_element_page_visibility branch from 6125aa5 to fb8a853 Compare July 15, 2022 03:22
@hailangvn

Copy link
Copy Markdown
Contributor Author

Thanks @leemannd for the comment. This PR has been updated.

@ofonseca-pyming ofonseca-pyming left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
functional review ok.

@Abranes Abranes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

LGTM

@simahawk

Copy link
Copy Markdown
Contributor

/ocabot migration report_qweb_element_page_visibility

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Dec 20, 2022
@yvaucher

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-634-by-yvaucher-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 9bb94f4 into OCA:15.0 Dec 21, 2022
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 470fb84. Thanks a lot for contributing to OCA. ❤️

@cvinh

cvinh commented Dec 21, 2022

Copy link
Copy Markdown

I did another PR here #702 not to lose this improvment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.