Skip to content

[16.0][MIG] report_xlsx_helper: Migration to 16.0 - #655

Merged
OCA-git-bot merged 53 commits into
OCA:16.0from
factorlibre:16.0-mig-report_xlsx_helper
Dec 5, 2022
Merged

OCA-git-bot merged 53 commits into
OCA:16.0from
factorlibre:16.0-mig-report_xlsx_helper

Conversation

@RodrigoBM

@RodrigoBM RodrigoBM commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

@oca-clabot

Copy link
Copy Markdown

Hey @RodrigoBM, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@RodrigoBM

Copy link
Copy Markdown
Contributor Author

/ocabot migration report_xlsx_helper

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Sorry @RodrigoBM you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@RodrigoBM RodrigoBM mentioned this pull request Oct 6, 2022
16 tasks
@baimont

baimont commented Oct 10, 2022

Copy link
Copy Markdown

Hi @RodrigoBM,
Thanks for this pr.

Can you fix red pre-commit and add report_xlsx to test-requirements.txt to fix runboat and tests?

Inspiration can be found there : OCA/queue@33cf163

Thanks!

@RodrigoBM
RodrigoBM force-pushed the 16.0-mig-report_xlsx_helper branch 2 times, most recently from 876354a to db7a9c2 Compare October 11, 2022 08:41
@RodrigoBM
RodrigoBM force-pushed the 16.0-mig-report_xlsx_helper branch 3 times, most recently from 81d8b10 to 503fda4 Compare October 11, 2022 09:08
@RodrigoBM

Copy link
Copy Markdown
Contributor Author

Hi @baimont

I hope this is OK now. But I don't know why the "tests / Detect unreleased dependencies (pull_request)" doesn't work.

Regards

@baimont

baimont commented Oct 11, 2022

Copy link
Copy Markdown

Hi @baimont

I hope this is OK now. But I don't know why the "tests / Detect unreleased dependencies (pull_request)" doesn't work.

Regards

Hi @RodrigoBM
Thanks for your changes.
This is normal.
tests / Detect unreleased dependencies is there to remind you you'll have to remove the last commit once your dependency is merged.

@RodrigoBM

Copy link
Copy Markdown
Contributor Author

Okey,
Thanks @baimont

@RodrigoBM
RodrigoBM force-pushed the 16.0-mig-report_xlsx_helper branch from 503fda4 to d924b58 Compare December 4, 2022 16:09
@RodrigoBM RodrigoBM changed the title [MIG] report_xlsx_helper: Migration to 16.0 [16.0][MIG] report_xlsx_helper: Migration to 16.0 Dec 4, 2022
@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot migration report_xlsx_helper
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 5, 2022
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-655-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit ba84a0a into OCA:16.0 Dec 5, 2022
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at babc717. Thanks a lot for contributing to OCA. ❤️

@RodrigoBM
RodrigoBM deleted the 16.0-mig-report_xlsx_helper branch December 5, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.