[16.0] [MIG] report_xml - #663
Merged
Merged
Conversation
Almost any XML must start with this. Let's make it easier.
Any report inheriting this AbstractModel can check its XML results against any XSD.
Previous instructions were misleading
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-report_xml Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xml/
* No longer need `with Environment.manage()` * Assets are registered in manifest file now * ReportController endpoints no longer take a `token` parameter * The frontend ActionManager has been rewritten as an Owl service
Currently translated at 94.4% (17 of 18 strings) Translation: reporting-engine-15.0/reporting-engine-15.0-report_xml Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-15-0/reporting-engine-15-0-report_xml/ca/
Member
Author
etobella
approved these changes
Oct 18, 2022
etobella
left a comment
Member
There was a problem hiding this comment.
Functional review.
Worked like a charm 😄 Thanks for the refactoring of the JS
👍
Member
|
/ocabot migration report_xml |
Member
|
/ocabot merge nobump |
Member
Author
|
@pedrobaeza |
Member
|
/ocabot merge nobump |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 5a67a6c. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration to
16.0.Since odoo 16.0 is on a theme of making the thing run faster, thought some optimization changes could be made.
Slightly reworked the controller, renamed the file to more match the current odoo file structure.
Controller got reworked in a more logical manner, looked through illogical lines, and merged some if statements.
Cleaned up the
.jsfile to make it more readable (offered a similar change in oca/server-tools/pull/2329)Hard-coded in some variables that are related to
xmlreport (if we print a xml report it won't become a pdf out of thin air).Of course did all the necessary changes to make the thing run.
Also what the hell is that lang "mechanism"?
Like, I get it, but why?