[17.0][MIG] report_substitute: Migration to 17.0 - #828
Conversation
This addon give the possibility to substitute a report action by another based on some criteria.
Currently translated at 100.0% (21 of 21 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_substitute Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_substitute/es/
2ff3cdc to
68ae4da
Compare
atchuthan
left a comment
There was a problem hiding this comment.
Please add changes available in adhoc-dev#1
Code migration is not complete when we used the initial commit, we made corrections and sent PR.
| class MailThread(models.AbstractModel): | ||
| _inherit = "mail.thread" | ||
|
|
||
| def message_post_with_template(self, template_id, **kwargs): |
There was a problem hiding this comment.
Este método cambió
ahora es message_post_with_source
ver en este commit (odoo/odoo@4775bd9)
29a842b to
633f9ba
Compare
|
This PR has the |
|
@sbejaoui can we get this merged? |
|
@lef-adhoc |
633f9ba to
156ccf0
Compare
| ): | ||
| template, view = self._get_source_from_ref(source_ref) | ||
| old_report_template_ids = False | ||
| if template.report_template_ids and self.ids: |
There was a problem hiding this comment.
We are getting this error, when template is false.
File "/opt/odoo/sodtest17-odoo/src/community_modules_links/report_substitute/models/mail_thread.py", line 21, in message_post_with_source
if template.report_template_ids and self.ids:
AttributeError: 'bool' object has no attribute 'report_template_ids'
156ccf0 to
410659a
Compare
|
@SodexisTeam Could you check if it is ok now? |
SodexisTeam
left a comment
There was a problem hiding this comment.
Tested and it looks good 👍
|
This PR has the |
|
@OCA/reporting-engine-maintainers can we merge this PR? |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at eb60a15. Thanks a lot for contributing to OCA. ❤️ |
No description provided.