[16.0][MIG] report_qweb_signer by benwillig · Pull Request #836 · OCA/reporting-engine

benwillig · 2024-01-10T08:37:03Z

No description provided.

len-foss

LGTM with a minor change :-)

len-foss · 2024-01-17T19:30:53Z

+                    ).format(
+                        error_code=process.returncode,


I think OCA guidelines are to avoid string formatting with format as it has more security risks. Note that you can keep your change by simply replacing the changes by %(message)s, see odoo/odoo@3c3b88f.

Yes, this is required, good spot! Newer guidelines also require to use named placeholders when multiple placeholders appear in the same translated string, so just follow @len-foss' suggestion and you'll be good to go.

sorry for the delay, it should be fixed now

OCA-git-bot · 2024-01-17T19:31:30Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

edlopen · 2024-02-26T11:31:05Z

LGTM, thank you @benwillig.

edlopen · 2024-02-26T11:34:01Z

Hello @OCA/reporting-engine-maintainers ,

I have tested the module and I think it is ready to be merged. Can you take a look please?

Thank you!!

yajo · 2024-03-27T11:22:40Z

+                    ).format(
+                        error_code=process.returncode,


Yes, this is required, good spot! Newer guidelines also require to use named placeholders when multiple placeholders appear in the same translated string, so just follow @len-foss' suggestion and you'll be good to go.

EmilioPascual · 2024-04-16T08:28:02Z

@yajo can you review again please, plz? @benwillig updated pr

yajo · 2024-04-17T12:35:23Z

It seems the branch has conflicts. Can you please rebase and fix them, so we can merge?

OCA Transbot updated translations from Transifex

These limits were being hit when printing PDF reports with just 80 pages. OCA Transbot updated translations from Transifex [UPD] Update report_qweb_signer.pot

- Good dependency chain - Context for forcing rendering PDF - Extra test [UPD] README.rst [UPD] Update report_qweb_signer.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_qweb_signer/ [UPD] README.rst

`render_qweb_pdf` must return a tuple of `(content, 'pdf')`

Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_qweb_signer/

Fix website on manifest

Currently translated at 26.0% (12 of 46 strings) Translation: reporting-engine-14.0/reporting-engine-14.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-report_qweb_signer/it/

Currently translated at 63.0% (29 of 46 strings) Translation: reporting-engine-14.0/reporting-engine-14.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-report_qweb_signer/sl/

Currently translated at 100.0% (46 of 46 strings) Translation: reporting-engine-14.0/reporting-engine-14.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-report_qweb_signer/ca/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-14.0/reporting-engine-14.0-report_qweb_signer Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-14-0/reporting-engine-14-0-report_qweb_signer/

benwillig · 2024-04-17T13:16:27Z

It seems the branch has conflicts. Can you please rebase and fix them, so we can merge?

@yajo Rebased

EmilioPascual · 2024-04-18T08:14:35Z

@benwillig error with pre-commit. Please, fix. Thank you

OCA-git-bot · 2024-04-22T10:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

yajo · 2024-04-22T12:39:05Z

/ocabot merge patch

OCA-git-bot · 2024-04-22T12:39:29Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-836-by-yajo-bump-patch, awaiting test results.

OCA-git-bot · 2024-04-22T12:48:16Z

Congratulations, your PR was merged at a91bc0f. Thanks a lot for contributing to OCA. ❤️

benwillig force-pushed the 16.0-mig-report_qweb_signer-bwi branch from 571be0c to 3e0d0d6 Compare January 10, 2024 08:42

benwillig changed the title ~~[MIG][16.0] report_qweb_signer~~ [16.0][MIG] report_qweb_signer Jan 10, 2024

ThomasBinsfeld approved these changes Jan 10, 2024

View reviewed changes

benwillig mentioned this pull request Jan 10, 2024

[16.0][MIG] report_py3o_signer #837

Open

len-foss approved these changes Jan 17, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Jan 17, 2024

ThomasBinsfeld force-pushed the 16.0-mig-report_qweb_signer-bwi branch from 3e0d0d6 to b7ea37b Compare February 12, 2024 09:47

yajo requested changes Mar 27, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Mar 27, 2024

benwillig force-pushed the 16.0-mig-report_qweb_signer-bwi branch from b7ea37b to 0041e0c Compare March 27, 2024 13:54

yajo approved these changes Apr 17, 2024

View reviewed changes

antespi and others added 12 commits April 17, 2024 15:14

report_qweb_signer addon

ce7daad

report_qweb_signer: Add feature request

d37b5c6

OCA Transbot updated translations from Transifex

[MIG] report_qweb_signer: Migration to 10.0

3481056

OCA Transbot updated translations from Transifex

fix test_report_qweb_signer - tests were causing travis to stall

5ef6693

[FIX] report_qweb_signer: Remove hardcoded memory limits

2585a99

These limits were being hit when printing PDF reports with just 80 pages. OCA Transbot updated translations from Transifex [UPD] Update report_qweb_signer.pot

[FIX] README syntax

584cc3e

[MIG] report_qweb_designer: Migration to 12.0

20994f5

[FIX] report_qweb_signer: reprint report crash

c0f4a6d

`render_qweb_pdf` must return a tuple of `(content, 'pdf')`

[FIX] report_qweb_signer

dc9337c

Fix website on manifest

[IMP] report_qweb_signer: Black python code

157fc58

OCA-git-bot and others added 13 commits April 17, 2024 15:14

report_qweb_signer 14.0.2.0.1

88fadb6

Update CONFIGURE.rst

d9ee778

[UPD] README.rst

5db975c

report_qweb_signer 14.0.2.0.2

f4579c4

[UPD] README.rst

613e11b

[IMP] pre-commit lint

95c3157

[UPD] Update report_qweb_signer.pot

592cf56

[BOT] post-merge updates

13dcc35

benwillig force-pushed the 16.0-mig-report_qweb_signer-bwi branch from 0041e0c to b12eec8 Compare April 17, 2024 13:15

[MIG] report_qweb_signer to 16.0

30257d2

benwillig force-pushed the 16.0-mig-report_qweb_signer-bwi branch from b12eec8 to 30257d2 Compare April 22, 2024 08:41

EmilioPascual approved these changes Apr 22, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 22, 2024

OCA-git-bot added the bot is merging ⏳ label Apr 22, 2024

OCA-git-bot merged commit dbe3401 into OCA:16.0 Apr 22, 2024

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 22, 2024

ThomasBinsfeld deleted the 16.0-mig-report_qweb_signer-bwi branch June 10, 2024 12:48

Uh oh!

Uh oh!

Conversation

benwillig commented Jan 10, 2024

Uh oh!

len-foss left a comment

Choose a reason for hiding this comment

Uh oh!

len-foss Jan 17, 2024

Choose a reason for hiding this comment

Uh oh!

yajo Mar 27, 2024

Choose a reason for hiding this comment

Uh oh!

benwillig Mar 27, 2024

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Jan 17, 2024

Uh oh!

edlopen commented Feb 26, 2024

Uh oh!

edlopen commented Feb 26, 2024

Uh oh!

yajo Mar 27, 2024

Choose a reason for hiding this comment

Uh oh!

EmilioPascual commented Apr 16, 2024

Uh oh!

yajo commented Apr 17, 2024

Uh oh!

benwillig commented Apr 17, 2024

Uh oh!

EmilioPascual commented Apr 18, 2024

Uh oh!

OCA-git-bot commented Apr 22, 2024

Uh oh!

yajo commented Apr 22, 2024

Uh oh!

OCA-git-bot commented Apr 22, 2024

Uh oh!

OCA-git-bot commented Apr 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants