[MIG] auth_user_case_insensitive: Migration to 12.0 - #104
Conversation
|
Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-12.0 |
…f `_login` * Update code and tests to override `_login` method
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
This comment has been minimized.
This comment has been minimized.
|
What should I do about CLA problem? I am not associated with Mr. Salmon, or LasLabs. |
|
@Retropikzel don't worry about that complaint, as it's a gap in our bot. Please fix Travis however. |
|
@pedrobaeza The only error I can see in the travis check is this one: I'm not sure that this error is linked to the |
|
Yeah, that one is the problem. You have to use |
|
I will try to look at this tomorrow at OCA sprint. |
|
Hi @pedrobaeza , I have fixed the travis error with a @Retropikzel I have created a PR to your branch https://github.com/Retropikzel/server-auth/pull/1. |
…case_insensitive [FIX] auth_user_case_insensitive: LDAP error in tests
|
@pedrobaeza Travis check are fixed. :) Thanks for your hints. |
|
You can now look for a second reviewer reviewing you other PRs and ask for it in exchange |
|
Looks good, and tested the logic on runbot with different spellings of admin |
|
This PR has the |
|
Well, reviews come from non PSC members, but everything green + the hope you become more active in OCA :) get me to request the merge: /ocabot merge |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@pedrobaeza Thank you. :) |
|
Congratulations, your PR was merged at 191da97. Thanks a lot for contributing to OCA. ❤️ |
| """ It should verify the login is set to lowercase on login """ | ||
| rec_id = self._new_record() | ||
| # We have to commit this cursor, because `_login` uses a fresh cursor | ||
| self.env.cr.commit() |
There was a problem hiding this comment.
Oops... this passed unnoticed? A commit in a test is a time bomb... 😱 💣
Syncing from upstream OCA/server-auth (13.0)
No description provided.