Skip to content

[MIG] auth_user_case_insensitive: Migration to 12.0 - #104

Merged
OCA-git-bot merged 18 commits into
12.0from
unknown repository
Oct 7, 2019
Merged

OCA-git-bot merged 18 commits into
12.0from
unknown repository

Conversation

@ghost

@ghost ghost commented May 28, 2019

Copy link
Copy Markdown

No description provided.

@pedrobaeza pedrobaeza added this to the 12.0 milestone May 28, 2019
@pedrobaeza

Copy link
Copy Markdown
Member

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-12.0

@oca-clabot

This comment has been minimized.

@emagdalenaC2i emagdalenaC2i mentioned this pull request Jun 1, 2019
19 tasks
@ghost

ghost commented Jul 3, 2019

Copy link
Copy Markdown
Author

What should I do about CLA problem? I am not associated with Mr. Salmon, or LasLabs.

@pedrobaeza

Copy link
Copy Markdown
Member

@Retropikzel don't worry about that complaint, as it's a gap in our bot.

Please fix Travis however.

@remytms

remytms commented Sep 30, 2019

Copy link
Copy Markdown
Contributor

@pedrobaeza The only error I can see in the travis check is this one:

ERROR openerp_test odoo.addons.auth_ldap.models.res_company_ldap: An LDAP exception occurred: {'desc': "Can't contact LDAP server"}

I'm not sure that this error is linked to the auth_user_case_insensitive. What do you think ?

@pedrobaeza

Copy link
Copy Markdown
Member

Yeah, that one is the problem. You have to use mute_logger in that test for avoiding the log complaint, although you check that the raise is happening.

@remytms

remytms commented Sep 30, 2019

Copy link
Copy Markdown
Contributor

I will try to look at this tomorrow at OCA sprint.

@remytms

remytms commented Oct 1, 2019

Copy link
Copy Markdown
Contributor

Hi @pedrobaeza ,
Hi @Retropikzel ,

I have fixed the travis error with a mute_logger as suggested. See this commit coopiteasy@f67ab2f.

@Retropikzel I have created a PR to your branch https://github.com/Retropikzel/server-auth/pull/1.

…case_insensitive

[FIX] auth_user_case_insensitive: LDAP error in tests

@remytms remytms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :)

@remytms

remytms commented Oct 7, 2019

Copy link
Copy Markdown
Contributor

@pedrobaeza Travis check are fixed. :) Thanks for your hints.

@pedrobaeza

Copy link
Copy Markdown
Member

You can now look for a second reviewer reviewing you other PRs and ask for it in exchange

@jarmokortetjarvi

Copy link
Copy Markdown
Contributor

Looks good, and tested the logic on runbot with different spellings of admin

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza

Copy link
Copy Markdown
Member

Well, reviews come from non PSC members, but everything green + the hope you become more active in OCA :) get me to request the merge: /ocabot merge

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-104-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 7, 2019
Signed-off-by pedrobaeza
@ghost

ghost commented Oct 7, 2019

Copy link
Copy Markdown
Author

@pedrobaeza Thank you. :)

@OCA-git-bot
OCA-git-bot merged commit f3a10d7 into OCA:12.0 Oct 7, 2019
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 191da97. Thanks a lot for contributing to OCA. ❤️

""" It should verify the login is set to lowercase on login """
rec_id = self._new_record()
# We have to commit this cursor, because `_login` uses a fresh cursor
self.env.cr.commit()

@yajo yajo Mar 26, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops... this passed unnoticed? A commit in a test is a time bomb... 😱 💣

SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-auth (13.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.