[12.0][mig] auth_totp - #114
Closed
fkantelberg wants to merge 23 commits into
Closed
fkantelberg wants to merge 23 commits into
fkantelberg wants to merge 23 commits into
Conversation
…sers model * Overload check_credentials in res.users to allow for logins using an MFA login token rather than a password * Add the res.users.authenticator and res.users.device models, along with appropriate ACLs and record rules * Add the res.users.authenticator.create wizard model and an associated view to facilitate creation of res.users.authenticator records * Extend base.view_users_form_simple_modif with fields needed to manage the new functionality * Add an AuthTotp controller that inherits from Home in the web module and an associated view to introduce MFA logic to the login process * Add several new exception classes that inherit from AccessDenied
…es to odoo * Bump version * Add pyotp back to requirements
…* Replace LasLabs logo with OCA one * Overload _build_model in res.users model to add two MFA fields to the model class's list of self-writeable fields, allowing these fields to be edited by users without admin permissions for their own record * Update view_users_form_simple_modif and the unit tests in the module based on the self-writeable field change
…ew for admin access * Update record rules to give admins read/unlink access to MFA authenticators
…thenticator.create wizard model to properly support deletion of users who have just created an MFA authenticator
…ying the decorator on one of the routes and updating the login_success request parameter as needed
…gic that checks for the Firefox edge case where redirect_with_hash returns a Response object rather than a string * Add test case for this scenario
…c to prevent RPC authentication for users with MFA enabled and add support for multiple simultaneous MFA sessions * Switch trusted device cookies from using the DB secret to user-level secret keys, thereby increasing security * Remove MFA login tokens and trusted device model, which are now redundant * Add migration logic that generates a trusted device cookie key for every user with MFA enabled and cleans up device model ir records to prevent warnings * Update unit tests and remainder of module accordingly
… users with MFA enabled even when those users have recently logged in
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-11.0/server-auth-11.0-auth_totp Translate-URL: https://translation.odoo-community.org/projects/server-auth-11-0/server-auth-11-0-auth_totp/
fkantelberg
force-pushed
the
12.0_mig_auth_totp
branch
from
June 22, 2019 11:36
b33f0a9 to
8f96b8e
Compare
fkantelberg
force-pushed
the
12.0_mig_auth_totp
branch
from
June 22, 2019 17:30
a124919 to
31c11a9
Compare
1 task
fkantelberg
force-pushed
the
12.0_mig_auth_totp
branch
from
July 12, 2019 11:14
ea3f628 to
6058b20
Compare
tbaden
approved these changes
Jul 12, 2019
tbaden
left a comment
Member
There was a problem hiding this comment.
thanks for the work 👍
I did a code review: LGTM
Contributor
|
This PR has the |
|
@lmignon @pedrobaeza can you guys merge this one please, really looking forward to having TOTP in Odoo 12 |
Member
|
/ocabot merge |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
OCA-git-bot
added a commit
that referenced
this pull request
Aug 9, 2019
Contributor
|
Congratulations, your PR was merged at 9cc134b. Thanks a lot for contributing to OCA. ❤️ PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into |
|
thank you @pedrobaeza ! |
Member
Author
|
thank you @Nobd @pedrobaeza |
sonhd91
pushed a commit
to camptocamp/server-auth
that referenced
this pull request
Jul 29, 2024
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-auth
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-auth (11.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I migrated and tested it with different users. Seems to be stable so far despite the changes in odoo 12.