Skip to content

[12.0][MIG] auth_admin_passkey - #116

Closed
fkantelberg wants to merge 53 commits into
OCA:12.0from
initOS:12.0_mig_auth_admin_passkey
Closed

fkantelberg wants to merge 53 commits into
OCA:12.0from
initOS:12.0_mig_auth_admin_passkey

Conversation

@fkantelberg

Copy link
Copy Markdown
Member

Hi,

this is the migration of the auth_admin_passkey from v10.

Because of the concerns regarding to the GDPR from the mailing list I'll try to suggest some further improvements in a following PR.

@fkantelberg
fkantelberg force-pushed the 12.0_mig_auth_admin_passkey branch from 23d6655 to 58cefeb Compare June 28, 2019 13:07
@pedrobaeza pedrobaeza added this to the 12.0 milestone Jun 28, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 28, 2019
19 tasks
@mohamedhagag

Copy link
Copy Markdown

just tested it , working fine .

legalsylvain and others added 26 commits July 8, 2019 13:35
… user_id == SUPERUSER_ID. (Courtesy of Stefan Rijnhart).
…same password as the admin user, sending a mail to admin user.
…llation of modules 'auth_admin_passkey' and 'auth_crypt'. (Courtesy of Stefan Rijnhart).
…[REF] res_users.py : same call to self.pool in other res_users class.
oca-transbot and others added 19 commits July 8, 2019 13:35
this fixes an issue reported on Transifex
Remove authenticate as check_credentials is dedicated for this
purpose.

Removed mail translations maybe possible in some way ?
Give some space to the code

Make the addon compliant to OCA guidelines
Adapt readme to new template and compress header in tests
Make the addon a python package

NOTE: authenticate() method cannot be used in tests because a new cr
is created in _login method that does not contains our user.

Signed-off-by: Eugen Don <eugen.don@don-systems.de>
…email. If a normal user and the administrator have the same password, an AccessError is raised (email of the admin account can not be read) and no security alert is sent by email
Currently translated at 90.9% (10 of 11 strings)

Translation: server-tools-10.0/server-tools-10.0-auth_admin_passkey
Translate-URL: https://translation.odoo-community.org/projects/server-tools-10-0/server-tools-10-0-auth_admin_passkey/pt/
@fkantelberg
fkantelberg force-pushed the 12.0_mig_auth_admin_passkey branch from 58cefeb to 86f4358 Compare July 8, 2019 11:37
@alexis-via

Copy link
Copy Markdown
Contributor

When using this PR, we get this warning in the logs of Odoo:

2019-07-23 12:03:44,077 31490 WARNING test1 odoo.addons.base.models.res_config: Methods that start with `get_default_` are deprecated. Override `get_values` instead(Method get_default_auth_admin_passkey_send_to_admin) 
2019-07-23 12:03:44,077 31490 WARNING test1 odoo.addons.base.models.res_config: Methods that start with `get_default_` are deprecated. Override `get_values` instead(Method get_default_auth_admin_passkey_send_to_user)

@fkantelberg

Copy link
Copy Markdown
Member Author

@alexis-via Should be removed now.

@mohamedhagag

Copy link
Copy Markdown

Should we merge ?

@fkantelberg

Copy link
Copy Markdown
Member Author

As promised the suggested improvement regarding the GDPR in #129.

SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-auth (12.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.