[12.0][MIG] users_ldap_mail - #151
Conversation
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
* [ADD] Add README.rst to users_ldap_mail * [MIG] Migrate users_ldap_mail to 10.0 * [FIX] Fixes in code style in module users_ldap_mail Changes in models/users_ldap_mail include: - remove unused imports - indentation of too long lines * [FIX] users_ldap_mail: Fix copyright notice * [FIX] users_ldap_mail: set UTF-8 encoding users_ldap_mail/models/__init__.py should be UTF-8 encoded * [FIX] users_ldap_mail: remove size argument from Char fields * [FIX] users_ldap_mail: return value can be combined in one line * [FIX] Update read me Fixes included: - Make module name human readable - Instead of numbering steps, use # - Update broken link
|
Hey @Tardo, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
chienandalu
left a comment
There was a problem hiding this comment.
Would it be very hard to achieve full coverage?
pedrobaeza
left a comment
There was a problem hiding this comment.
Can you squash a bit the commit history?
05233e6 to
d0e69b1
Compare
|
@chienandalu The module only overwrite 'email' and 'name' values of the res.users record... Make tests for this module isn't a trivial task... All other changes done! |
|
Ok, great :) |
|
/ocabot merge |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at df4d5c6. Thanks a lot for contributing to OCA. ❤️ |
Syncing from upstream OCA/server-auth (12.0)
cc @Tecnativa TT18055