Skip to content

[11.0] [MIG] users ldap mail - #2

Merged
lasley merged 31 commits into
OCA:11.0from
etobella:11.0-mig-users_ldap_mail
Oct 20, 2017
Merged

lasley merged 31 commits into
OCA:11.0from
etobella:11.0-mig-users_ldap_mail

Conversation

@etobella

Copy link
Copy Markdown
Member

Migration to 11.0.
Same code that existed on #1 and OCA/server-tools#1018.

dreispt and others added 29 commits October 10, 2017 17:03
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
* [ADD] Add README.rst to users_ldap_mail

* [MIG] Migrate users_ldap_mail to 10.0

* [FIX] Fixes in code style in module  users_ldap_mail

Changes in models/users_ldap_mail include:
 - remove unused imports
 - indentation of too long lines

* [FIX] users_ldap_mail: Fix copyright notice

* [FIX] users_ldap_mail: set UTF-8 encoding

users_ldap_mail/models/__init__.py should be UTF-8 encoded

* [FIX] users_ldap_mail: remove size argument from Char fields

* [FIX] users_ldap_mail: return value can be combined in one line

* [FIX] Update read me

Fixes included:
 - Make module name human readable
 - Instead of numbering steps, use #
 - Update broken link

@lasley lasley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Thanks!

Comment thread users_ldap_mail/__manifest__.py Outdated
'version': "10.0.1.0.0",
'version': "11.0.1.0.0",
'depends': ["auth_ldap"],
'author': "Daniel Reis (https://launchpad.com/~dreis-pt),"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreispt - are you good with removing your launchpad from this?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, of course 😄

@@ -0,0 +1,15 @@
<?xml version="1.0"?>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align file name with contribution guidelines

res_company_ldap_view.xml

@etobella
etobella force-pushed the 11.0-mig-users_ldap_mail branch from 6c1a2ca to 74bc9a1 Compare October 18, 2017 07:30
@etobella
etobella force-pushed the 11.0-mig-users_ldap_mail branch from 74bc9a1 to d427cd6 Compare October 19, 2017 10:05
@JordiBForgeFlow

Copy link
Copy Markdown
Member

This one is ready to merge.

@lasley
lasley merged commit ccbde61 into OCA:11.0 Oct 20, 2017
@lasley

lasley commented Oct 20, 2017

Copy link
Copy Markdown
Contributor

I think this is the first v11 I've merged. Merging this many commits is intimidating.

@lasley

lasley commented Oct 20, 2017

Copy link
Copy Markdown
Contributor

Btw thanks @etobella! 😉

@dreispt

dreispt commented Oct 22, 2017

Copy link
Copy Markdown
Member

@lasley Not really: only the two last commits are new; the rest is just module history.

@pedrobaeza

Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza added this to the 11.0 milestone Oct 31, 2017
lalithkota pushed a commit to lalithkota/oca-server-auth that referenced this pull request Aug 3, 2023
Added extra authorize params. Fixed pre-commit errors and remove comm…
SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-auth (11.0)
yibudak added a commit to altinkaya-opensource/server-auth that referenced this pull request Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.