Conversation
|
Hi, Raph, can you Travis and runbot status? |
* Add keychain module
Readme: (in example) prefix function with _ Dep: add a depency to base_setup in order to use xml id "base.menu_config"
Remove explicit dependency to base.
…he integration of keychain when you already have /need the concept of backend
remove coding utf8 add base_sparse_field to get Serialized fields run 2to3 bump version manual adaptation of python3
96fcf27 to
3d4ef97
Compare
|
OCB branch is good now, thanks Pedro |
|
Can you please attend these warnings (it's a new Odoo check): |
[11.0] keychain: improve ACL and allow storing ssh keys as password OCA#30
|
so if I'am right, this PR is superseded by this one #39, right? |
rousseldenis
left a comment
There was a problem hiding this comment.
LGTM. Some comments
@hparfr Could we try to move forward on this one ?
| try: | ||
| return self._decode_password(self.password) | ||
| except Warning as warn: | ||
| raise Warning(_( |
There was a problem hiding this comment.
IMHO this is incorrect to raise not ORM exceptions.
| data = fields.Text(help="Additionnal data as json") | ||
|
|
||
| def _compute_password(self): | ||
| # Only needed in v8 for _description_searchable issues |
There was a problem hiding this comment.
I think this can be removed
| """At this time there is no namespace set.""" | ||
| if not vals.get('data') and not self.data: | ||
| vals['data'] = self._serialize_data(self._init_data()) | ||
| return super(KeychainAccount, self).write(vals) |
There was a problem hiding this comment.
Can be simplified
| return super(KeychainAccount, self).write(vals) | |
| return super().write(vals) |
|
@rousseldenis |
|
@florian-dacosta Ok, thanks. @hparfr Could you close ? |
Syncing from upstream OCA/server-auth (9.0)
No description provided.