Skip to content

[10.0] add auth_api_key - #51

Merged
gurneyalex merged 18 commits into
OCA:10.0from
acsone:10.0-add-auth_api_key
Dec 11, 2018
Merged

[10.0] add auth_api_key#51
gurneyalex merged 18 commits into
OCA:10.0from
acsone:10.0-add-auth_api_key

Conversation

@qgroulard

@qgroulard qgroulard commented Nov 6, 2018

Copy link
Copy Markdown
Contributor

Authenticate http requests from an API key.
See readme for further information.

@oca-clabot

oca-clabot commented Nov 6, 2018

Copy link
Copy Markdown

Hey @qgroulard, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@qgroulard

qgroulard commented Nov 6, 2018

Copy link
Copy Markdown
Contributor Author

@lmignon

@sbidoul

sbidoul commented Nov 6, 2018

Copy link
Copy Markdown
Member

@qgroulard is covered by ACSONE ECLA.

sbidoul
sbidoul reviewed Nov 6, 2018
View reviewed changes
Comment thread auth_api_key/readme/CONFIGURE.rst Outdated
sbidoul
sbidoul reviewed Nov 6, 2018
View reviewed changes
Comment thread auth_api_key/readme/DESCRIPTION.rst Outdated
lmignon
lmignon requested changes Nov 7, 2018
View reviewed changes

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @qgroulard for this work and welcome into OCA!
The code is clean, with tests and doc. It's a great job and a great first contribution.
I made a few comments to aim for perfection. 😏

Comment thread auth_api_key/readme/CONTRIBUTORS.rst Outdated
Comment thread auth_api_key/readme/DESCRIPTION.rst Outdated
Comment thread auth_api_key/__manifest__.py
Comment thread auth_api_key/models/ir_http.py
@oca-clabot

oca-clabot commented Nov 7, 2018

Copy link
Copy Markdown

Hey @qgroulard,
We acknowledge that the following users have signed our Contributor License Agreement:

Appreciation of efforts,
OCA CLAbot

lmignon
lmignon approved these changes Nov 8, 2018
View reviewed changes

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @qgroulard

@lmignon

lmignon commented Nov 12, 2018

Copy link
Copy Markdown
Contributor

@qgroulard Can you check and fix errors in travis...

lmignon
lmignon requested changes Nov 13, 2018
View reviewed changes
Comment thread auth_api_key/models/ir_http.py Outdated
Comment thread auth_api_key/models/ir_http.py Outdated
@lmignon

lmignon commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

OCA/server-tools#1425 should fix travis and runbot

@sbidoul

sbidoul commented Nov 19, 2018

Copy link
Copy Markdown
Member

I restarted the build. Now it complains about the missing running_env config entry.

The solution is to add it in travis-ci.yml.

@lmignon

lmignon commented Nov 19, 2018

Copy link
Copy Markdown
Contributor

@sbidoul done and 🍏

sbidoul
sbidoul reviewed Nov 19, 2018
View reviewed changes
Comment thread auth_api_key/models/ir_http.py
@sbidoul

sbidoul commented Nov 20, 2018

Copy link
Copy Markdown
Member

@lmignon @sebastienbeau @hparfr would you agree to change the license of this one to LGPL before merging? The reason is it's a low level technical module, LGPL allows to use it more different contexts.

@sbidoul sbidoul mentioned this pull request Nov 20, 2018
Merged
1 task
@lmignon

lmignon commented Nov 20, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

@sbidoul I agree. 👍

@hparfr

hparfr commented Nov 20, 2018

Copy link
Copy Markdown
Contributor

Ok for me

@sebastienbeau

sebastienbeau commented Nov 20, 2018

Copy link
Copy Markdown
Member

@sbidoul ok for me too. I also approve the change in this PR

@OCA-git-bot

OCA-git-bot commented Nov 20, 2018

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@lmignon lmignon changed the title [10.0] add auth_api_key [WIP][10.0] add auth_api_key Nov 21, 2018
@lmignon

lmignon commented Nov 21, 2018

Copy link
Copy Markdown
Contributor

Title changed to WIP since the licence will be changed

@sbidoul sbidoul changed the title [WIP][10.0] add auth_api_key [10.0] add auth_api_key Nov 21, 2018
@sbidoul

sbidoul commented Nov 21, 2018

Copy link
Copy Markdown
Member

License changed

@lmignon

lmignon commented Nov 21, 2018

Copy link
Copy Markdown
Contributor

Thank you @sbidoul

ap-wtioit
ap-wtioit reviewed Nov 30, 2018
View reviewed changes
Comment thread auth_api_key/models/auth_api_key.py Outdated
@sbidoul

sbidoul commented Nov 30, 2018

Copy link
Copy Markdown
Member

@qgroulard can you check the travis errors?

@ap-wtioit @qgroulard @lmignon
Use consteq to compare keys
d698d61 
Co-Authored-By: qgroulard <43472442+qgroulard@users.noreply.github.com>
@lmignon
lmignon force-pushed the 10.0-add-auth_api_key branch from f9779e5 to d698d61 Compare November 30, 2018 18:38
@gurneyalex
gurneyalex merged commit d8e15fe into OCA:10.0 Dec 11, 2018
@sbidoul
sbidoul deleted the 10.0-add-auth_api_key branch January 25, 2019 08:37
SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024
@bt-admin
Merge pull request OCA#51 from OCA/11.0
626e044 
Syncing from upstream OCA/server-auth (11.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmignon lmignon lmignon approved these changes
@sbidoul sbidoul sbidoul left review comments
@sebastienbeau sebastienbeau sebastienbeau approved these changes
@gurneyalex gurneyalex gurneyalex approved these changes
+1 more reviewer
@ap-wtioit ap-wtioit ap-wtioit left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved needs review ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@qgroulard @oca-clabot @sbidoul @lmignon @hparfr @sebastienbeau @OCA-git-bot @gurneyalex @ap-wtioit @RobinetDenisAcsone