Skip to content

[17.0][MIG] base_user_show_email: Migration to 17.0 - #605

Closed
lav-adhoc wants to merge 14 commits into
OCA:17.0from
adhoc-dev:17.0-mig-base_user_show_email
Closed

lav-adhoc wants to merge 14 commits into
OCA:17.0from
adhoc-dev:17.0-mig-base_user_show_email

Conversation

@lav-adhoc

Copy link
Copy Markdown
Contributor

No description provided.

@lav-adhoc lav-adhoc changed the title 17.0 mig base user show email [17.0][MIG] base_user_show_email: Migration to 17.0 Jan 23, 2024
@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 26, 2024
@github-actions github-actions Bot closed this Jun 30, 2024
@lav-adhoc

Copy link
Copy Markdown
Contributor Author

@sbidoul
Hello, can you re-open this pr and review it? thanks

@lav-adhoc

Copy link
Copy Markdown
Contributor Author

@pedrobaeza hi Pedro, can you re-open this pr and review it? thanks

@pedrobaeza

Copy link
Copy Markdown
Member

I'm not able to re-open it, sorry.

@sbidoul sbidoul reopened this Oct 23, 2024
@sbidoul sbidoul removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 23, 2024
@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot migration base_user_show_email

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Oct 23, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 23, 2024
21 tasks
@lav-adhoc

Copy link
Copy Markdown
Contributor Author

@pedrobaeza @sbidoul thanks. what i have to do with the error in the coverage? Add some tests?

@pedrobaeza

Copy link
Copy Markdown
Member

Codecov is not mandatory. It's just a metric to show the code not covered by tests (and sometimes lies).

@lav-adhoc

Copy link
Copy Markdown
Contributor Author

@sbidoul hi, can you merge it? thanks

@lav-adhoc

Copy link
Copy Markdown
Contributor Author

@pedrobaeza hi, can you merge it? thanks

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It contains the infamous .deb package that must be removed, and the changes in README.rst are not in the proper commit. Please redo the migration again. At the end, it's only to switch 16 to 17.

@github-actions

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 16, 2025
@github-actions github-actions Bot closed this Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants