[12.0][MIG] auth_saml by gurneyalex · Pull Request #64 · OCA/server-auth

gurneyalex · 2018-12-11T15:07:34Z

No description provided.

pedrobaeza · 2018-12-11T15:09:32Z

@probabble @alexey-pelykh you can now review this one.

gurneyalex · 2018-12-11T15:12:16Z

caution: PR is hot from the oven, and not tested yet with a real SAML server. The code installs, the views display AFAICT. I'll be testing soon to assert if this works, but I need to get my hands on my customer's sysadmin 😸 In the meanwhile if you are able to test this in real, I'll be more than happy

blop · 2019-03-06T15:59:19Z

Testing the auth_saml in v12 :)

blop · 2019-03-08T10:55:14Z

Have anyone succeeded in making this module work on a v12 ?

yajo

Lots of things to fix/improve.

Also, rebase to fix conflicts please.

Thanks for your contribution!

yajo

Lots of things to fix/improve.

Also:

Include newer history from 11.0 branch: https://github.com/OCA/server-auth/commits/11.0/auth_saml
rebase to fix conflicts please.

Thanks for your contribution!

[IMP] Cleanup

The following line of code for 11.0: - https://github.com/odoo/odoo/blob/52d6f0e3ee90874fc93fec9cdff74ec71d3b991f/addons/auth_oauth/controllers/main.py#L69 is assigning the key "auth_link" for "list_providers" method. The following template is expecting this key: - https://github.com/odoo/odoo/blob/52d6f0e3ee90874fc93fec9cdff74ec71d3b991f/addons/auth_oauth/views/auth_oauth_templates.xml#L5 So, it raise a KeyError compiling "template_auth_oauth_providers_N" This change is fixing adding that expected key in order to avoid this KeyError

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-11.0/server-auth-11.0-auth_saml Translate-URL: https://translation.odoo-community.org/projects/server-auth-11-0/server-auth-11-0-auth_saml/

[FIX] dependencies

add requirement on lasso

yajo

I applied suggestions myself.

@Tecnativa TT22174

Tardo

Looks good! only few comments....

yajo

All attended.

yajo

This is now ready to merge.

gurneyalex

approved --but can't self approve --

code review, no test

pedrobaeza · 2020-03-26T15:47:06Z

@yajo, please check Travis

- Default behavior is now to allow password and SAML together. Otherwise, users could keep getting their passwords removed without warning. - General cleanup. - Remove relations to field `password_crypt` because in v12 the `password` field is always encrypted instead. Co-Authored-By: Alexandre Díaz <alexandre.diaz@tecnativa.com>

yajo · 2020-03-27T12:08:56Z

All green now.

pedrobaeza · 2020-03-27T15:47:17Z

/ocabot merge

OCA-git-bot · 2020-03-27T15:47:32Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-64-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot · 2020-03-27T15:59:06Z

Congratulations, your PR was merged at d463522. Thanks a lot for contributing to OCA. ❤️

NuevaIT-ext1 · 2020-10-01T05:24:30Z

i am new here and i found and error in auth_saml.py,line 50 lasso.Server
module 'lasso' has no attribute 'Server'

eLBati · 2020-11-16T16:25:48Z

@NuevaIT-ext1 you need to install the "Free Liberty Alliance Implementation" https://lasso.entrouvert.org/

https://packages.ubuntu.com/focal/python3-lasso

Syncing from upstream OCA/server-auth (12.0)

gurneyalex changed the title ~~12.0 mig auth saml~~ [12.0][MIG] auth_saml Dec 11, 2018

pedrobaeza added this to the 12.0 milestone Dec 11, 2018

OCA-git-bot mentioned this pull request Dec 11, 2018

Migration to version 12.0 #38

Closed

19 tasks

gurneyalex added the work in progress label Dec 11, 2018

gurneyalex force-pushed the 12.0-mig_auth_saml branch from 8a89b9b to e0a4ac5 Compare December 11, 2018 18:47

gurneyalex removed the work in progress label Dec 11, 2018

gurneyalex force-pushed the 12.0-mig_auth_saml branch from e0a4ac5 to f2b9511 Compare December 13, 2018 14:06

yajo requested changes Mar 9, 2020

View reviewed changes

max3903 and others added 11 commits March 19, 2020 13:51

[IMP] Move files in a subdirectory

784c732

[IMP] Cleanup

[MIG] auth_saml: Migration to 11.0

8a02cb0

Typo

759fd59

[UPD] Update auth_saml.pot

ebe7c52

[ADD] icon.png

315c9d9

[FIX] auth_saml: Remove broken symlink

7ca47b1

[UPD] Update auth_saml.pot

00e7a87

Update translation files

9b4efd5

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-11.0/server-auth-11.0-auth_saml Translate-URL: https://translation.odoo-community.org/projects/server-auth-11-0/server-auth-11-0-auth_saml/

[FIX] dependencies

c86b208

[FIX] dependencies

[MIG] auth_saml to 12.0

cf0ecc7

add requirement on lasso

yajo force-pushed the 12.0-mig_auth_saml branch from f2b9511 to b9a6ae3 Compare March 19, 2020 14:10

yajo added enhancement migration labels Mar 19, 2020

yajo approved these changes Mar 19, 2020

View reviewed changes

yajo force-pushed the 12.0-mig_auth_saml branch from b9a6ae3 to a8d71a0 Compare March 19, 2020 14:11

Tardo suggested changes Mar 19, 2020

View reviewed changes

yajo force-pushed the 12.0-mig_auth_saml branch from 4ebd488 to b6da85c Compare March 20, 2020 10:45

yajo approved these changes Mar 20, 2020

View reviewed changes

Comment thread auth_saml/controllers/main.py

Comment thread auth_saml/models/saml_token.py

Comment thread auth_saml/security/auth_saml.xml

yajo force-pushed the 12.0-mig_auth_saml branch 4 times, most recently from 0d47788 to afdb38a Compare March 26, 2020 11:51

yajo approved these changes Mar 26, 2020

View reviewed changes

gurneyalex commented Mar 26, 2020

View reviewed changes

yajo force-pushed the 12.0-mig_auth_saml branch from afdb38a to 668c2db Compare March 27, 2020 09:00

yajo force-pushed the 12.0-mig_auth_saml branch from 668c2db to f56b4bd Compare March 27, 2020 09:23

OCA-git-bot merged commit e1c687e into OCA:12.0 Mar 27, 2020

OCA-git-bot added the merged 🎉 label Mar 27, 2020

SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024

Merge pull request OCA#64 from OCA/12.0

49048ef

Syncing from upstream OCA/server-auth (12.0)

Uh oh!

Conversation

gurneyalex commented Dec 11, 2018

Uh oh!

pedrobaeza commented Dec 11, 2018

Uh oh!

gurneyalex commented Dec 11, 2018

Uh oh!

blop commented Mar 6, 2019

Uh oh!

blop commented Mar 8, 2019

Uh oh!

yajo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yajo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yajo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tardo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yajo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yajo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gurneyalex left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Mar 26, 2020

Uh oh!

yajo commented Mar 27, 2020

Uh oh!

pedrobaeza commented Mar 27, 2020

Uh oh!

OCA-git-bot commented Mar 27, 2020

Uh oh!

OCA-git-bot commented Mar 27, 2020

Uh oh!

NuevaIT-ext1 commented Oct 1, 2020

Uh oh!

eLBati commented Nov 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

yajo left a comment •

edited

Loading

yajo left a comment •

edited

Loading

yajo left a comment •

edited

Loading