Skip to content

[MIG] auth_oauth_autologin: Migration to 17.0 - #658

Merged
OCA-git-bot merged 13 commits into
OCA:17.0from
Ontinet-com:17.0-mig-auth_oauth_autologin
Jun 14, 2025
Merged

[MIG] auth_oauth_autologin: Migration to 17.0#658
OCA-git-bot merged 13 commits into
OCA:17.0from
Ontinet-com:17.0-mig-auth_oauth_autologin

Conversation

@Loregs2

@Loregs2 Loregs2 commented Jun 4, 2024

Copy link
Copy Markdown
Contributor

Standard migration to 17.0

@Loregs2
Loregs2 force-pushed the 17.0-mig-auth_oauth_autologin branch from 1d47425 to db20dff Compare June 11, 2024 12:05
@Loregs2 Loregs2 changed the title [MIG] auth_oauth_autologin: Migration to 17.0 WIP: [MIG] auth_oauth_autologin: Migration to 17.0 Jun 11, 2024
@Loregs2
Loregs2 marked this pull request as draft June 11, 2024 12:06
@Loregs2 Loregs2 changed the title WIP: [MIG] auth_oauth_autologin: Migration to 17.0 [MIG] auth_oauth_autologin: Migration to 17.0 Jun 11, 2024
@Loregs2
Loregs2 force-pushed the 17.0-mig-auth_oauth_autologin branch from db20dff to deaec3a Compare June 12, 2024 14:59
@Loregs2
Loregs2 marked this pull request as ready for review June 12, 2024 15:03
@jaenbox

jaenbox commented Jun 14, 2024

Copy link
Copy Markdown

LGTM

@CasVissers-360ERP

CasVissers-360ERP commented Aug 23, 2024

Copy link
Copy Markdown
Contributor

@Loregs2 /web/login?no_autologin not working at the moment similar to #627

@benwillig

benwillig commented Aug 28, 2024 •
edited
Loading

Copy link
Copy Markdown

@CasVissers-360ERP @Loregs2 I pushed a fix for the ?no_autologin

@github-actions

github-actions Bot commented Dec 29, 2024

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 29, 2024
@anikeenko-viktor

anikeenko-viktor commented Jan 13, 2025

Copy link
Copy Markdown

This module works for me. What needs to be done to have it merged?

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 19, 2025
@github-actions

github-actions Bot commented May 25, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 25, 2025
@Loregs2
Loregs2 force-pushed the 17.0-mig-auth_oauth_autologin branch from deaec3a to b4073a5 Compare June 2, 2025 15:04
@Loregs2

Loregs2 commented Jun 2, 2025

Copy link
Copy Markdown
Contributor Author

This module works for me. What needs to be done to have it merged?

You can check ‘Approve’ in the Review changes section of the files, thanks.

@benwillig

benwillig commented Jun 2, 2025

Copy link
Copy Markdown

@Loregs2 fix with ?no_autologin is not included unless it's not needed anymore? https://github.com/OCA/server-auth/pull/627/files#diff-f3238b0909b811978b1f783e9dde0a41031587b3de012f0356a68c81c855e043R15

Otherwise it looks ok

@Loregs2
Loregs2 force-pushed the 17.0-mig-auth_oauth_autologin branch from b4073a5 to 8234cc9 Compare June 3, 2025 10:37
@Loregs2

Loregs2 commented Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

@Loregs2 fix with ?no_autologin is not included unless it's not needed anymore? https://github.com/OCA/server-auth/pull/627/files#diff-f3238b0909b811978b1f783e9dde0a41031587b3de012f0356a68c81c855e043R15

Otherwise it looks ok

You were right, I have added that change and the ?no_autologin is now working. Thank you.

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 8, 2025
@dreispt

dreispt commented Jun 14, 2025

Copy link
Copy Markdown
Member

/ocabot migration auth_oauth_autologin
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 14, 2025
@OCA-git-bot

OCA-git-bot commented Jun 14, 2025

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-658-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jun 14, 2025
Open
21 tasks
@OCA-git-bot
OCA-git-bot merged commit 5739039 into OCA:17.0 Jun 14, 2025
@OCA-git-bot

OCA-git-bot commented Jun 14, 2025

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 27778a4. Thanks a lot for contributing to OCA. ❤️

@Abranes
Abranes deleted the 17.0-mig-auth_oauth_autologin branch July 29, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreispt dreispt dreispt approved these changes
+2 more reviewers
@jaenbox jaenbox jaenbox approved these changes
@benwillig benwillig benwillig approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

17.0

Development

Successfully merging this pull request may close these issues.

10 participants

@Loregs2 @jaenbox @CasVissers-360ERP @benwillig @anikeenko-viktor @dreispt @OCA-git-bot @sbidoul @oca-travis @rousseldenis