Skip to content

[17.0][MIG] users_ldap_groups: Migration to 17.0 - #673

Merged
OCA-git-bot merged 37 commits into
OCA:17.0from
ryanc-me:17.0-mig-users_ldap_groups
Aug 11, 2025
Merged

[17.0][MIG] users_ldap_groups: Migration to 17.0#673
OCA-git-bot merged 37 commits into
OCA:17.0from
ryanc-me:17.0-mig-users_ldap_groups

Conversation

@ryanc-me

@ryanc-me ryanc-me commented Jul 30, 2024

Copy link
Copy Markdown

No description provided.

This was referenced Jul 30, 2024
Open
Merged
@pedrobaeza

pedrobaeza commented Sep 23, 2024

Copy link
Copy Markdown
Member

Is this still draft? Please include #596

dreispt and others added 27 commits November 27, 2024 14:27
@dreispt @ryanc-me
Therp's modules to sync OpenERP with LDAP directories
73dfd3c
@dreispt @ryanc-me
FIX version numbers; view type is deprecated
19b0210
Sandy Carter @ryanc-me
Generate .pot files
0e4595d
@yajo @ryanc-me
Write needs list to browse.
7c10296
@sbidoul @ryanc-me
move all modules to __unported__ on master branch and set installable…
1a879b0 
…=False
@giacomos85 @ryanc-me
start moving the users_ldap_groups outside the __unported__ folder
0c14960
@giacomos85 @ryanc-me
porting to v8
a7c7862
@giacomos85 @ryanc-me
move to new apis
cece24b
@giacomos85 @ryanc-me
fix missing new api call
9394254
@giacomos85 @ryanc-me
some makeup and change the ldap operators from plain python objects t…
ea46909 
…o a transientmodel
@giacomos85 @ryanc-me
use AbstractModel instead of TransientModel so we don't create useles…
781a5aa 
…s db tables
@giacomos85 @ryanc-me
change description with summary to have the following sentence show u…
56d41c5 
…p beneath the module's name in kanban view
@yvaucher @ryanc-me
Add missing default oca icons
1ad4045
@sbidoul @ryanc-me
[UPD] prefix versions with 8.0
57d069c
@pedrobaeza @ryanc-me
[MIG] Make modules uninstallable
8fd49a8
@pedrobaeza @ryanc-me
[MIG] Rename manifest files
d3eac2a
@hbrunn @ryanc-me
[MIG] users_ldap_groups
c0070ba
@sbidoul @ryanc-me
remove obsolete .pot files [ci skip]
7293d4f
@alexey-pelykh @ryanc-me
[MIG] users_ldap_groups: Migration to 12.0
cb4e73a
@badbole @ryanc-me
Added translation using Weblate (Croatian)
08bfee8
@alexey-pelykh @ryanc-me
[UPD] Brainbean Apps => CorporateHub
f85218c
@joao-p-marques @ryanc-me
[IMP] users_ldap_groups: black, isort, prettier
78acb04
@joao-p-marques @ryanc-me
[MIG] users_ldap_groups: Migration to 13.0
741c34d
@joao-p-marques @ryanc-me
[IMP] users_ldap_groups: Check and warn about wrong user config
d78f178 
Also improve tests and handle new warning
@dsolanki-initos @ryanc-me
[IMP] users_ldap_groups: Black, Isort, Prettier.
6f67825
@dsolanki-initos @ryanc-me
[MIG] Migrate module users_ldap_groups to v14.
17fd1e2
@ortlam @ryanc-me
[MIG] users_ldap_groups: Migration to 15.0
52c94b9
@carolinafernandez-tecnativa @ryanc-me
[MIG] users_ldap_groups: Migration to 16.0
c6b91ad
@Ivorra78 @ryanc-me
Translated using Weblate (Spanish)
9d1efbd 
Currently translated at 100.0% (26 of 26 strings)

Translation: server-auth-16.0/server-auth-16.0-users_ldap_groups
Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-users_ldap_groups/es/
@mymage @ryanc-me
Translated using Weblate (Italian)
807736b 
Currently translated at 100.0% (26 of 26 strings)

Translation: server-auth-16.0/server-auth-16.0-users_ldap_groups
Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-users_ldap_groups/it/
@oh2fih @ryanc-me
[16.0][FIX] users_ldap_groups: vulnerability
fcf7d3c 
res.company.ldap.operator operators should be private methods;
public methods allow arbitrary LDAP queries via JSON-API
Rodrigo Macedo @ryanc-me
Translated using Weblate (Portuguese (Brazil))
9c0920b 
Currently translated at 100.0% (26 of 26 strings)

Translation: server-auth-16.0/server-auth-16.0-users_ldap_groups
Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-users_ldap_groups/pt_BR/
@oh2fih @hparfr @ryanc-me
users_ldap_groups update docstring on operators()
d6614a3 
Co-authored-by: Hpar <raph@hpar.fr>
@ryanc-me
[IMP] users_ldap_groups: pre-commit auto fixes
d8d1bec
@ryanc-me
[MIG] users_ldap_groups: Migrate to 17.0
f8fb37d
@ryanc-me
Fix issue with mock cursor in tests
6ee2755
@oh2fih @ryanc-me
[16.0][FIX] users_ldap_groups: safe LDAP decode
59ee980 
The group mapping in query mode fails if LDAP returns binary data in any
of the fields. This adds a function that handles such situation by
base64 encoding it.
The new test test_users_ldap_groups_ldap_returns_binary_data covers
the common case where LDAP return binary data in thumbnailPhoto.
@ryanc-me
ryanc-me force-pushed the 17.0-mig-users_ldap_groups branch from 1a89c3b to 59ee980 Compare November 27, 2024 01:27
@ryanc-me
ryanc-me marked this pull request as ready for review November 27, 2024 01:32
@ryanc-me

ryanc-me commented Nov 27, 2024

Copy link
Copy Markdown
Author

@pedrobaeza what is the policy re codecov failure for migrations?

@pedrobaeza

pedrobaeza commented Nov 27, 2024

Copy link
Copy Markdown
Member

It's not mandatory, so don't worry too much in migrations.

@ryanc-me

ryanc-me commented Nov 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Author

Thanks Pedro, that's good to know.

@cvinh any chance you could review this one also?

@github-actions

github-actions Bot commented Mar 30, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 30, 2025
@ryanc-me

ryanc-me commented Mar 30, 2025

Copy link
Copy Markdown
Author

The technical migration is done, just waiting for a review.

If someone would like to review, and wants to help/support to set up the module, please let me know!

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 6, 2025
@github-actions

github-actions Bot commented Aug 10, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 10, 2025
pedrobaeza
pedrobaeza approved these changes Aug 11, 2025
View reviewed changes

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump
/ocabot migration users_ldap_groups

@OCA-git-bot

OCA-git-bot commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-673-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 11, 2025
@OCA-git-bot
OCA-git-bot merged commit 6f1d4f7 into OCA:17.0 Aug 11, 2025
0 of 2 checks passed
@OCA-git-bot

OCA-git-bot commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 3b3eb57. Thanks a lot for contributing to OCA. ❤️

@ap-wtioit ap-wtioit mentioned this pull request Nov 18, 2025
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees

No one assigned

Labels

merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

17.0

Development

Successfully merging this pull request may close these issues.