Skip to content

[18.0][MIG] auth_admin_passkey: Migration to 18.0 - #740

Merged
OCA-git-bot merged 87 commits into
OCA:18.0from
BT-dlagin:18.0-mig-auth_admin_passkey
Jan 3, 2025
Merged

OCA-git-bot merged 87 commits into
OCA:18.0from
BT-dlagin:18.0-mig-auth_admin_passkey

Conversation

@BT-dlagin

Copy link
Copy Markdown
Contributor

No description provided.

legalsylvain and others added 30 commits December 20, 2024 11:03
…ion if user_id == SUPERUSER_ID. (Courtesy of Stefan Rijnhart).
…s the same password as the admin user, sending a mail to admin user.
… installation of modules 'auth_admin_passkey' and 'auth_crypt'. (Courtesy of Stefan Rijnhart).
…xxx']

[REF] res_users.py : same call to self.pool in other res_users class.
[ADD] Test #1 to OCA#5 to avoid regression;
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
mymage and others added 5 commits December 20, 2024 11:03
Currently translated at 100.0% (3 of 3 strings)

Translation: server-auth-17.0/server-auth-17.0-auth_admin_passkey
Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-auth_admin_passkey/it/
In the res_users.py file, the `ignore_totp` session variable is now set based on the value of the `auth_admin_passkey_ignore_totp` configuration option. If the option is enabled, the `ignore_totp` session variable is set to True. This ensures that the `_mfa_url` method returns None when `ignore_totp` is True, effectively bypassing the 2FA check.
@BT-dlagin
BT-dlagin force-pushed the 18.0-mig-auth_admin_passkey branch 4 times, most recently from 37f98fc to fda78d0 Compare December 20, 2024 13:52

@BT-dmoreno BT-dmoreno left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the code coverage errors, for the reset, the code looks good.

@BT-dlagin
BT-dlagin force-pushed the 18.0-mig-auth_admin_passkey branch from fda78d0 to fccb724 Compare January 2, 2025 15:27
@BT-dlagin
BT-dlagin force-pushed the 18.0-mig-auth_admin_passkey branch from fccb724 to 0772cac Compare January 2, 2025 15:31
@BT-dlagin

Copy link
Copy Markdown
Contributor Author

Please take a look at the code coverage errors, for the reset, the code looks good.

Added more tests, now all checks have passed.

@BT-dlagin

Copy link
Copy Markdown
Contributor Author

@OCA/tools-maintainers Hello :) can somebody do a review for me?
Thanks!

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sebalix sebalix left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@sebalix

sebalix commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

/ocabot migration auth_admin_passkey

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 3, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 3, 2025
23 tasks
@sebalix

sebalix commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-740-by-sebalix-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 1b84593 into OCA:18.0 Jan 3, 2025
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 1d1ad6b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.