[12.0][MIG] Module auth_u2f by fkantelberg · Pull Request #90 · OCA/server-auth

fkantelberg · 2019-04-26T12:42:20Z

Hello,
I would like to share the migration of the module aufh_u2f to version 12.0.

fkantelberg · 2019-06-25T06:01:05Z

@pedrobaeza I have no idea why the runbot is failing. I tested it locally without a problem and I can even access the runbot. Would you mind labelling it with needs_review?

pedrobaeza · 2019-07-02T11:43:16Z

It's a runbot warning:

2019-06-22 06:39:04,018 172 WARNING openerp_test odoo.models: The model u2f.device has no _description

fkantelberg · 2019-07-07T09:21:49Z

@pedrobaeza Thanks for the hint 👍

tbaden

thanks for the work 👍
I did a code review: LGTM

tbaden · 2019-07-12T13:22:50Z

+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <data>
+        <record id="view_users_form_inherit_auth_u2f" model="ir.ui.view">


optional change:
use original id (view_users_form)

tbaden · 2019-07-12T13:23:30Z

+            <field name="domain">[('user_id', '=', uid)]</field>
+        </record>
+
+        <record id="view_users_form_simple_modif_inherit_auth_u2f" model="ir.ui.view">


optional change:
use original id (view_users_form_simple_modif)

yucer · 2019-07-12T14:42:06Z

It is great code.

Just one question about this call

Should one verify the previous result from super() before making the extra verification ?

If super fails, there is no need.

At least that the failed authentication trigger one exception.

fkantelberg · 2019-07-12T14:48:15Z

If super fails it fails with an exception the result isn't really important in that case.

yucer

Clean code.

fkantelberg · 2019-08-30T09:53:28Z

@pedrobaeza Can we merge this?

pedrobaeza · 2019-08-30T10:21:12Z

/ocabot merge

OCA-git-bot · 2019-08-30T10:21:19Z

@pedrobaeza The merge process could not start, because command git rebase --autosquash 12.0 failed with output:

First, rewinding head to replay your work on top of it...
Applying: Add auth_u2f module
Applying: [UPD] README.rst
Applying: [UPD] Update auth_u2f.pot
Applying: [ADD] icon.png
Applying: Adjust to odoo 12.0
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging requirements.txt
CONFLICT (add/add): Merge conflict in requirements.txt
error: Failed to merge in the changes.
Patch failed at 0005 Adjust to odoo 12.0
Use 'git am --show-current-patch' to see the failed patch

Resolve all conflicts manually, mark them as resolved with
"git add/rm <conflicted_files>", then run "git rebase --continue".
You can instead skip this commit: run "git rebase --skip".
To abort and get back to the state before "git rebase", run "git rebase --abort".

pedrobaeza · 2019-08-30T10:22:29Z

Please solve the conflict.

fkantelberg · 2019-08-30T12:08:48Z

@pedrobaeza
Should work now.

pedrobaeza · 2019-08-30T23:29:53Z

/ocabot merge

OCA-git-bot · 2019-08-30T23:30:17Z

Hey, thanks for contributing! Proceeding to merge this for you.
Rebased to 12.0-ocabot-merge-pr-90-by-pedrobaeza-bump-no, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2019-08-30T23:42:20Z

Congratulations, your PR was merged at 255e6ed. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 12.0.

Syncing from upstream OCA/server-auth (10.0)

pedrobaeza added this to the 12.0 milestone Apr 26, 2019

OCA-git-bot mentioned this pull request Apr 26, 2019

Migration to version 12.0 #38

Closed

19 tasks

fkantelberg force-pushed the 12.0_mig_auth_u2f branch 2 times, most recently from a95fac6 to e7081d8 Compare April 26, 2019 13:49

fkantelberg force-pushed the 12.0_mig_auth_u2f branch from e7081d8 to 9ced84e Compare May 27, 2019 15:53

fkantelberg force-pushed the 12.0_mig_auth_u2f branch from 9ced84e to 12a338c Compare June 9, 2019 19:41

fkantelberg force-pushed the 12.0_mig_auth_u2f branch 4 times, most recently from 77321f5 to 9ce03c8 Compare July 7, 2019 09:06

fkantelberg force-pushed the 12.0_mig_auth_u2f branch 2 times, most recently from dbe40d9 to a73a54c Compare July 12, 2019 13:19

tbaden approved these changes Jul 12, 2019

View reviewed changes

yucer approved these changes Jul 12, 2019

View reviewed changes

fkantelberg and others added 5 commits August 30, 2019 13:21

Add auth_u2f module

0c58a8f

[UPD] README.rst

fbd4d92

[UPD] Update auth_u2f.pot

90bf17d

[ADD] icon.png

1423d5f

Adjust to odoo 12.0

788b2ec

fkantelberg force-pushed the 12.0_mig_auth_u2f branch from a44cd52 to 788b2ec Compare August 30, 2019 11:21

OCA-git-bot added a commit that referenced this pull request Aug 30, 2019

Merge PR #90 into 12.0

255e6ed

Signed-off-by pedrobaeza

OCA-git-bot added the merged 🎉 label Aug 30, 2019

OCA-git-bot closed this Aug 30, 2019

SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024

Merge pull request OCA#90 from OCA/10.0

26559a5

Syncing from upstream OCA/server-auth (10.0)

Uh oh!

Conversation

fkantelberg commented Apr 26, 2019

Uh oh!

fkantelberg commented Jun 25, 2019

Uh oh!

pedrobaeza commented Jul 2, 2019

Uh oh!

fkantelberg commented Jul 7, 2019

Uh oh!

tbaden left a comment

Choose a reason for hiding this comment

Uh oh!

tbaden Jul 12, 2019

Choose a reason for hiding this comment

Uh oh!

tbaden Jul 12, 2019

Choose a reason for hiding this comment

Uh oh!

yucer commented Jul 12, 2019

Uh oh!

fkantelberg commented Jul 12, 2019

Uh oh!

yucer left a comment

Choose a reason for hiding this comment

Uh oh!

fkantelberg commented Aug 30, 2019

Uh oh!

pedrobaeza commented Aug 30, 2019

Uh oh!

OCA-git-bot commented Aug 30, 2019

Uh oh!

pedrobaeza commented Aug 30, 2019

Uh oh!

fkantelberg commented Aug 30, 2019

Uh oh!

pedrobaeza commented Aug 30, 2019

Uh oh!

OCA-git-bot commented Aug 30, 2019

Uh oh!

OCA-git-bot commented Aug 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants