Skip to content

server_environment breaks existing installations #667

Description

@lasley

server_environment breaks existing installations by raising an Exception in the global namespace if there is a missing config variable - https://github.com/OCA/server-tools/blob/10.0/server_environment/serv_config.py#L39

I feel that this should instead be handled similar to our import guards, otherwise pulling this repo breaks things badly. It just happened to us on a production server.

If the Exception is truly necessary, it should be moved further back into the module itself. It should also be changed into an EnvironmentException at the very least.

@t3ddftw will be submitting a fix soon.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions