[12.0]base_exception Remove empty self feature. #1620

[hparfr]

This recently added feature is counter intuitive, error prone and is
already causing bugs in sale_workflow.

Like this:
https://github.com/OCA/sale-workflow/blob/10.0/sale_exception/models/sale_order_line.py#L28

(sale_order_line)
@api.multi
def _detect_exceptions(self, rule):
records = super(SaleOrderLine, self)._detect_exceptions(rule)
return records.mapped('order_id')

I think it's the correct and obvious way to write this code. But the actual implementation, will fail if the sale order has no lines. It will test exceptions on all the sale order line (empty self = search([])) and return exceptions tied to other sale orders.

Please merge it with a major version number bump.

same as #1620

[hparfr]

@florian-dacosta

[florian-dacosta]

thanks

[hparfr]

@yvaucher @guewen you can approve this one too

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[gurneyalex]

/ocabot merge major

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Rebased to 12.0-ocabot-merge-pr-1625-by-gurneyalex-bump-major, awaiting test results.

[yvaucher]

damn the merge failed here a while ago.

Will handle the rebase manually.

[yvaucher]

Seems it has already been merged there: 60d3d62