[14.0] Add module cron_daylight_saving_time_resistant - #2289
Conversation
|
The cron job required for this does take the user's time zone into account, does it? |
|
It does look like it takes the user into account when creating an env to take the timezone from? I like this a little bit better than this one, because it doesn't write to other cron jobs, it only writes to the next execution time of the current cron job, which seems less invasive to me and less prone to create conflict issues with other cron jobs. |
|
@NL66278 Maybe another review? |
|
Normally I would say that code should document itself, but I have a hard time understanding how this works. So some documentation of what happens seems to be in order. Then I might be able to do a proper review. |
|
@hparfr @clementmbr Since you reviewed the 16.0 version, maybe you can check if this one can be merged too? |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at ea93b08. Thanks a lot for contributing to OCA. ❤️ |
The module allows to configure crons so they always run at the same hour, no matter the timezone and the change of hours.
For instance, if you are in Brussels and you have a cron that run every days at 11H (local time), when swtiching from summer time to winter time, the cron will be planned for the next day at 10H (local time)
At the contrary when switching from winter time to summer time, the cron that was configured to run at 11H will be planned for 12H.
If it is important that the cron always run at the same hour no matter the change of time, then you can check the box "daylight_saving_time_resistant" on the cron.