Conversation
jcdrubay
commented
May 10, 2022
Contributor
- Add missing code for smart button
- shorten the README for better readability
legalsylvain
approved these changes
May 10, 2022
legalsylvain
left a comment
Contributor
There was a problem hiding this comment.
Thanks !
code review, no test.
thomaspaulb
approved these changes
Aug 1, 2022
Member
|
/ocabot merge patch |
Contributor
|
@dreispt The merge process could not start, because command `git merge --no-ff -m 'Merge PR #2337 into 15.0 Signed-off-by dreispt' tmp-pr-2337` failed with output: |
Member
|
Can you rebase and fix conflicts? |
Contributor
Member
|
Closing in favour of #2822 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.