Skip to content

Add module validator v8 - #238

Closed
hurrinico wants to merge 6 commits into
OCA:8.0from
hurrinico:add_module_validator_8
Closed

hurrinico wants to merge 6 commits into
OCA:8.0from
hurrinico:add_module_validator_8

Conversation

@hurrinico

Copy link
Copy Markdown

based on #84

@hurrinico

Copy link
Copy Markdown
Author

Actually this PR is Work In Progress

@pedrobaeza

Copy link
Copy Markdown
Member

Marked as WIP. Tell me when it's done to remove the label

@eLBati

eLBati commented Sep 1, 2015

Copy link
Copy Markdown
Member

👍
the WIP tag can be removed for me

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to add yourself as contributor

@hbrunn

hbrunn commented Sep 2, 2015

Copy link
Copy Markdown
Member

@hurrinico please lift the code to v8 api. I also put some comments to #84, they apply to this PR just the same

@lmignon

lmignon commented Sep 2, 2015

Copy link
Copy Markdown
Contributor

@hurrinico Is this PR a copy of #84 for 8.0? IMO, you should cherry-pick the commits from #84 to keep the history and make the changes required for 8.0 in a new commit.

@eLBati eLBati mentioned this pull request Sep 2, 2015
@eLBati

eLBati commented Sep 2, 2015

Copy link
Copy Markdown
Member

Let's continue on #246. Please close this

@lmignon I rebuilt the commit history based on 7.0 version

@hbrunn I partially ported the module to new API. It was partial because my mind exploded while trying to handle calls to write and create methods supporting both old and new API arguments

@lmignon

lmignon commented Sep 2, 2015

Copy link
Copy Markdown
Contributor

@eLBati Thank you for the rebase!

@hurrinico

Copy link
Copy Markdown
Author

This PR is moved to #246

StefanRijnhart pushed a commit to StefanRijnhart/server-tools that referenced this pull request Feb 26, 2017
[web_tree_image]: Add support for image resize
SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024
Syncing from upstream OCA/server-tools (9.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants