[17.0][FIX] module_analysis: interpret exclude_directories as relative to module's folder - #3045
Conversation
…e to module's folder Fixes OCA#3042.
|
Hi @legalsylvain, |
legalsylvain
left a comment
There was a problem hiding this comment.
Thanks a lot !
/ocabot merge patch
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@legalsylvain The merge process could not be finalized, because command |
|
@fcayre : could you rebase ? |
|
@legalsylvain my branch is already based on 17.0's head. oca-gen-addon-readme seems to generate the error ( |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@legalsylvain The merge process could not be finalized, because command |
|
@OCA/tools-maintainers : could we have some help here ? Step to reproduce :
docutils.utils.SystemMessage: ./module_analysis/README.rst:141: (ERROR/3) Duplicate substitution definition name: "image".
I suspect something wrong in the md -> rst conversion with many files. Thanks for your help ! |
Yes, looks like that; I think need to open an issue here Though I think I found out the solution: it works if you define unique captions for each image in the MD source files, that don't overlap with the ones automatically generated for the caption-less OCA images by Pandoc, which default to image, image1, image2... if the MD image captions overlap with those, errors occur. |
|
OK. I opened this issue : OCA/maintainer-tools#632 merging in the meantime, because it's a bugfix, and CI is green. |
|
How was CI green if |
|
CI was green, but merge bot commit failed. |
…e to module's folder Backport of PR OCA#3045.
…e to module's folder Backport of PR OCA#3045.
…e to module's folder Backport of PR OCA#3045.
…e to module's folder Backport of PR OCA#3045.
…e to module's folder Backport of PR OCA#3045.
…e to module's folder Backport of PR OCA#3045.
…e to module's folder Backport of PR OCA#3045.
…e to module's folder Backport of PR OCA#3045.

Fixes #3042.